Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2528083002: Bisect - Fix compare_samples to read scalar values. (Closed)

Created:
4 years ago by shatch
Modified:
4 years ago
Reviewers:
RobertoCN
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Bisect - Fix compare_samples to read scalar values. Previously it skipped them and that led to tests like Octane to fail bisects, since they'd never generate any values that could be used. BUG=chromium:668536 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/671a654736c219b9758b4393ae7f819c9df950cd

Patch Set 1 #

Patch Set 2 : Added test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -1 line) Patch
M tracing/tracing/metrics/compare_samples_cmdline.html View 1 chunk +2 lines, -0 lines 0 comments Download
M tracing/tracing/metrics/compare_samples_unittest.py View 1 2 chunks +41 lines, -1 line 0 comments Download

Messages

Total messages: 14 (10 generated)
RobertoCN
LGTM, though ideally we'd want to add a test to https://cs.chromium.org/chromium/src/third_party/catapult/tracing/tracing/metrics/compare_samples_unittest.py?type=cs&q=compare_samples_un&sq=package:chromium&l=1
4 years ago (2016-11-24 22:10:52 UTC) #7
shatch
On 2016/11/24 22:10:52, RobertoCN wrote: > LGTM, though ideally we'd want to add a test ...
4 years ago (2016-11-24 22:23:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2528083002/20001
4 years ago (2016-11-24 22:23:49 UTC) #11
commit-bot: I haz the power
4 years ago (2016-11-24 22:42:40 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698