Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: tracing/tracing/metrics/compare_samples_cmdline.html

Issue 2528083002: Bisect - Fix compare_samples to read scalar values. (Closed)
Patch Set: Added test. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tracing/tracing/metrics/compare_samples_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/metrics/compare_samples_cmdline.html
diff --git a/tracing/tracing/metrics/compare_samples_cmdline.html b/tracing/tracing/metrics/compare_samples_cmdline.html
index 36d42daaf15e621e4c916bcb1e0069c4829cd13b..3d9ce69d021868c339ae721047490ab1a077185d 100644
--- a/tracing/tracing/metrics/compare_samples_cmdline.html
+++ b/tracing/tracing/metrics/compare_samples_cmdline.html
@@ -77,6 +77,8 @@ function valuesFromCharts(listOfCharts, metricName) {
if (charts.charts[chartName][traceName].type === 'histogram')
allValues.push(
geoMeanFromHistogram(charts.charts[chartName][traceName]));
+ if (charts.charts[chartName][traceName].type === 'scalar')
+ allValues.push(charts.charts[chartName][traceName].value);
}
}
}
« no previous file with comments | « no previous file | tracing/tracing/metrics/compare_samples_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698