Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2528033002: [wasm] Add a flag --wasm-opt to test optimizations in the WASM pipeline. (Closed)

Created:
4 years ago by titzer
Modified:
4 years ago
Reviewers:
bradnelson, ahaas
CC:
Michael Hablich, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Add a flag --wasm-opt to test optimizations in the WASM pipeline. R=ahaas@chromium.org,bradnelson@chromium.org BUG= Committed: https://crrev.com/a0c518627f7950591923ef1397e9e4d7329b7c31 Cr-Commit-Position: refs/heads/master@{#41381}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix unittests #

Patch Set 3 : [wasm] Add a flag --wasm-opt to test optimizations in the WASM pipeline. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -36 lines) Patch
M src/compiler/machine-operator-reducer.cc View 2 chunks +13 lines, -14 lines 0 comments Download
M src/compiler/pipeline.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/compiler/pipeline.cc View 1 2 4 chunks +27 lines, -6 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/flag-definitions.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/wasm/wasm-run-utils.h View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/machine-operator-reducer-unittest.cc View 1 2 chunks +20 lines, -12 lines 0 comments Download

Messages

Total messages: 24 (16 generated)
titzer
4 years ago (2016-11-24 16:36:29 UTC) #1
bradnelson
lgtm
4 years ago (2016-11-24 20:53:48 UTC) #6
ahaas
lgtm with questions https://codereview.chromium.org/2528033002/diff/1/src/compiler/machine-operator-reducer.cc File src/compiler/machine-operator-reducer.cc (right): https://codereview.chromium.org/2528033002/diff/1/src/compiler/machine-operator-reducer.cc#newcode53 src/compiler/machine-operator-reducer.cc:53: Diamond d(graph(), common(), Why do you ...
4 years ago (2016-11-28 08:34:43 UTC) #7
titzer
https://codereview.chromium.org/2528033002/diff/1/src/compiler/machine-operator-reducer.cc File src/compiler/machine-operator-reducer.cc (right): https://codereview.chromium.org/2528033002/diff/1/src/compiler/machine-operator-reducer.cc#newcode53 src/compiler/machine-operator-reducer.cc:53: Diamond d(graph(), common(), On 2016/11/28 08:34:43, ahaas wrote: > ...
4 years ago (2016-11-28 09:30:22 UTC) #8
titzer
https://codereview.chromium.org/2528033002/diff/1/src/compiler/pipeline.cc File src/compiler/pipeline.cc (right): https://codereview.chromium.org/2528033002/diff/1/src/compiler/pipeline.cc#newcode127 src/compiler/pipeline.cc:127: javascript_(jsgraph->javascript()), On 2016/11/28 08:34:43, ahaas wrote: > I think ...
4 years ago (2016-11-28 09:31:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2528033002/40001
4 years ago (2016-11-30 10:34:18 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-11-30 10:36:01 UTC) #22
commit-bot: I haz the power
4 years ago (2016-11-30 10:36:23 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a0c518627f7950591923ef1397e9e4d7329b7c31
Cr-Commit-Position: refs/heads/master@{#41381}

Powered by Google App Engine
This is Rietveld 408576698