Source/core/editing/FormatBlockCommand.cpp - Issue 252783002: Make Range.detach() a no-op

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/FormatBlockCommand.cpp

Issue 252783002: Make Range.detach() a no-op (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/editing/FormatBlockCommand.cpp

diff --git a/Source/core/editing/FormatBlockCommand.cpp b/Source/core/editing/FormatBlockCommand.cpp

index 13510e43137fc33a75f0a340b337277a84f8b3d2..91f92293e1bf01fe92e77676b8a8afd8345cab1c 100644

--- a/Source/core/editing/FormatBlockCommand.cpp

+++ b/Source/core/editing/FormatBlockCommand.cpp

@@ -106,7 +106,7 @@ Element* FormatBlockCommand::elementForFormatBlockCommand(Range* range)

if (!range)

return 0;

- Node* commonAncestor = range->commonAncestorContainer(IGNORE_EXCEPTION);

+ Node* commonAncestor = range->commonAncestorContainer();

while (commonAncestor && !isElementForFormatBlock(commonAncestor))

commonAncestor = commonAncestor->parentNode();

« no previous file with comments | « Source/core/editing/EditorCommand.cpp ('k') | Source/core/editing/FrameSelection.cpp » ('j') | no next file with comments »