Source/core/editing/EditorCommand.cpp - Issue 252783002: Make Range.detach() a no-op

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/EditorCommand.cpp

Issue 252783002: Make Range.detach() a no-op (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/editing/EditorCommand.cpp

diff --git a/Source/core/editing/EditorCommand.cpp b/Source/core/editing/EditorCommand.cpp

index 5bb83cbb6b554fd24274942f4af31fb4eae79057..0ca0c7fde0c56c860c044e86191915e6a8aa94b0 100644

--- a/Source/core/editing/EditorCommand.cpp

+++ b/Source/core/editing/EditorCommand.cpp

@@ -216,7 +216,7 @@ static bool expandSelectionToGranularity(LocalFrame& frame, TextGranularity gran

RefPtrWillBeRawPtr<Range> newRange = selection.toNormalizedRange();

if (!newRange)

return false;

- if (newRange->collapsed(IGNORE_EXCEPTION))

+ if (newRange->collapsed())

return false;

EAffinity affinity = frame.selection().affinity();

frame.selection().setSelectedRange(newRange.get(), affinity, FrameSelection::CloseTyping);

« no previous file with comments | « Source/core/editing/Editor.cpp ('k') | Source/core/editing/FormatBlockCommand.cpp » ('j') | no next file with comments »