Make selfupdate maintain client version as well.

Make selfupdate maintain client version as well.

R=dnj@chromium.org, vadimsh@chromium.org
BUG=663843
Committed: https://github.com/luci/luci-go/commit/b6eff577b854a294dc37272e3f5c94b413b90ee8

[Vadim Sh., 2016-11-27 01:25:55]

lgtm with nits

https://codereview.chromium.org/2527753002/diff/1/cipd/client/cipd/client.go
File cipd/client/cipd/client.go (right):

https://codereview.chromium.org/2527753002/diff/1/cipd/client/cipd/client.go#...
cipd/client/cipd/client.go:726: vfStat, err := os.Stat(verFile)
I'd remove both of these checks and just read the file and compare its content
to what it should be, it is tiny. I don't like reliance on ModTime.

https://codereview.chromium.org/2527753002/diff/1/cipd/client/cipd/client.go#...
cipd/client/cipd/client.go:739: err = fs.EnsureFile(ctx, verFile, func(of
*os.File) error {
I forgot, does it create a full path? i.e. if ".versions" directory is missing?

https://codereview.chromium.org/2527753002/diff/1/cipd/version/version.go
File cipd/version/version.go (right):

https://codereview.chromium.org/2527753002/diff/1/cipd/version/version.go#new...
cipd/version/version.go:113: return readVersionFile(exePath + ".cipd_version")
note that there's a fallback here. It's where version files were before I moved
them to ".versions"... I believe it's fine to ignore it.

[iannucci, 2016-11-29 01:46:21]

Done

https://codereview.chromium.org/2527753002/diff/1/cipd/client/cipd/client.go
File cipd/client/cipd/client.go (right):

https://codereview.chromium.org/2527753002/diff/1/cipd/client/cipd/client.go#...
cipd/client/cipd/client.go:726: vfStat, err := os.Stat(verFile)
On 2016/11/27 01:25:55, Vadim Sh. wrote:
> I'd remove both of these checks and just read the file and compare its content
> to what it should be, it is tiny. I don't like reliance on ModTime.

Done.

https://codereview.chromium.org/2527753002/diff/1/cipd/client/cipd/client.go#...
cipd/client/cipd/client.go:739: err = fs.EnsureFile(ctx, verFile, func(of
*os.File) error {
On 2016/11/27 01:25:55, Vadim Sh. wrote:
> I forgot, does it create a full path? i.e. if ".versions" directory is
missing?

Yes :)

https://codereview.chromium.org/2527753002/diff/1/cipd/version/version.go
File cipd/version/version.go (right):

https://codereview.chromium.org/2527753002/diff/1/cipd/version/version.go#new...
cipd/version/version.go:113: return readVersionFile(exePath + ".cipd_version")
On 2016/11/27 01:25:55, Vadim Sh. wrote:
> note that there's a fallback here. It's where version files were before I
moved
> them to ".versions"... I believe it's fine to ignore it.

That's what I figured.

[iannucci, 2016-11-29 02:16:43]

The CQ bit was checked by iannucci@chromium.org

[iannucci, 2016-11-29 02:16:43]

The patchset sent to the CQ was uploaded after l-g-t-m from vadimsh@chromium.org
Link to the patchset: https://codereview.chromium.org/2527753002/#ps20001
(title: "Just read the file")

[commit-bot: I haz the power, 2016-11-29 02:16:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 02:20:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 02:20:37]

Try jobs failed on following builders:
  Luci-go Linux Trusty 64 Tester on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/32c6b07372135d10)
  Luci-go Mac Tester on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/32c6b073037fc210)

[iannucci, 2016-11-29 03:28:54]

The CQ bit was checked by iannucci@chromium.org

[iannucci, 2016-11-29 03:28:54]

The patchset sent to the CQ was uploaded after l-g-t-m from vadimsh@chromium.org
Link to the patchset: https://codereview.chromium.org/2527753002/#ps40001
(title: "Refactor so that tests can operate")

[commit-bot: I haz the power, 2016-11-29 03:28:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 03:34:27]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480390134334550,
"parent_rev": "dd65e8b8494aedf0eafff0ac6894a0c99e0a62ba", "commit_rev":
"b6eff577b854a294dc37272e3f5c94b413b90ee8"}

[commit-bot: I haz the power, 2016-11-29 03:34:29]

Description was changed from

==========
Make selfupdate maintain client version as well.

R=dnj@chromium.org, vadimsh@chromium.org
BUG=663843
==========

to

==========
Make selfupdate maintain client version as well.

R=dnj@chromium.org, vadimsh@chromium.org
BUG=663843

Committed:
https://github.com/luci/luci-go/commit/b6eff577b854a294dc37272e3f5c94b413b90ee8
==========

[commit-bot: I haz the power, 2016-11-29 03:34:30]

Committed patchset #3 (id:40001) as
https://github.com/luci/luci-go/commit/b6eff577b854a294dc37272e3f5c94b413b90ee8