Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4243)

Unified Diff: cipd/client/cipd/client_test.go

Issue 2527753002: Make selfupdate maintain client version as well. (Closed)
Patch Set: Refactor so that tests can operate Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cipd/client/cipd/client.go ('k') | cipd/version/version.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cipd/client/cipd/client_test.go
diff --git a/cipd/client/cipd/client_test.go b/cipd/client/cipd/client_test.go
index 6df3f3f4ca03a1cc8e8e4b2fc94ed7256577a814..1eb385e7d3cf84087861cfa5e5cc3780f5a56f9f 100644
--- a/cipd/client/cipd/client_test.go
+++ b/cipd/client/cipd/client_test.go
@@ -532,14 +532,15 @@ func TestMaybeUpdateClient(t *testing.T) {
ctx := makeTestContext()
Convey("MaybeUpdateClient", t, func() {
-
Convey("Is a NOOP when exeHash matches", func(c C) {
client := mockClient(c, "", nil)
client.tagCache = internal.NewTagCache(nil)
pin := common.Pin{clientPackage, "0000000000000000000000000000000000000000"}
So(client.tagCache.AddTag(ctx, pin, "git:deadbeef"), ShouldBeNil)
So(client.tagCache.AddFile(ctx, pin, clientFileName, "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"), ShouldBeNil)
- So(client.MaybeUpdateClient(ctx, nil, "git:deadbeef", "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa", "some_path"), ShouldBeNil)
+ pin, err := client.maybeUpdateClient(ctx, nil, "git:deadbeef", "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa", "some_path")
+ So(pin, ShouldResemble, pin)
+ So(err, ShouldBeNil)
})
})
}
« no previous file with comments | « cipd/client/cipd/client.go ('k') | cipd/version/version.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698