Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Unified Diff: runtime/vm/flow_graph_compiler.cc

Issue 25277002: Revert r28050 due to crashes with --optimization-counter-threshold=5. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/flow_graph_compiler.cc
===================================================================
--- runtime/vm/flow_graph_compiler.cc (revision 28051)
+++ runtime/vm/flow_graph_compiler.cc (working copy)
@@ -170,6 +170,13 @@
}
+static bool IsEmptyBlock(BlockEntryInstr* block) {
+ return !block->HasParallelMove() &&
+ block->next()->IsGoto() &&
+ !block->next()->AsGoto()->HasParallelMove();
+}
+
+
void FlowGraphCompiler::CompactBlock(BlockEntryInstr* block) {
BlockInfo* block_info = block_info_[block->postorder_number()];
@@ -179,7 +186,7 @@
}
block_info->mark();
- if (block->IsEmptyBlock()) {
+ if (IsEmptyBlock(block)) {
// For empty blocks, record a corresponding nonempty target as their
// jump label.
BlockEntryInstr* target = block->next()->AsGoto()->successor();

Powered by Google App Engine
This is Rietveld 408576698