add has_element_in_any_list check in ElementAnimations::UpdateActivation

cc/animation/element_animations.cc

Index: cc/animation/element_animations.cc
diff --git a/cc/animation/element_animations.cc b/cc/animation/element_animations.cc
index f8a7e9e9bef15e53dfa6504c74bc2f24867d0169..f178d6c7237dee2e13c8e790c937178202e47b7d 100644
--- a/cc/animation/element_animations.cc
+++ b/cc/animation/element_animations.cc
@@ -159,8 +159,10 @@ void ElementAnimations::PushPropertiesTo(
 
 void ElementAnimations::Animate(base::TimeTicks monotonic_time) {
   DCHECK(!monotonic_time.is_null());
-  if (!has_element_in_active_list() && !has_element_in_pending_list())
+  if (!has_element_in_active_list() && !has_element_in_pending_list()) {
+    animation_host_->DidDeactivateElementAnimations(this);

[loyso (OOO), 2016/11/27 23:36:55]

if you call host_->UnregisterElement, ElementAnimations::ElementUnregistered
should be called. I belive, DidDeactivate is called in
ElementAnimations::ElementUnregistered for the main thread.

For the impl thread: On PushProperties, ElementAnimations::UpdateActivation is
called.

It looks like we need to fix ElementAnimations::UpdateActivation (add the
has_element_in_any_list() check there). ::UpdateActivation is the actual
command, ::Animate is a regular general tick.

What do you think?

[junchao.han, 2016/11/28 04:09:03]

Thanks for the comments. Not DidActivateElementAnimations in PushProperties is a
better way than DidDeactivateElementAnimations in the general tick. A new patch
has been upload and PTAL. The new patch checks has_element_in_any_list in
UpdateActivation. However this patch will cause following two cc_unittests
failed. I will take a look.

LayerTreeHostAnimationTestAnimatedLayerRemovedAndAdded.RunMultiThread_DelegatingRenderer
LayerTreeHostAnimationTestAnimatedLayerRemovedAndAdded.RunSingleThread_DelegatingRenderer

     return;
+  }
 
   for (auto& player : players_list_) {
     if (player.needs_to_start_animations())