add has_element_in_any_list check in ElementAnimations::UpdateActivation

cc/animation/element_animations.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/animation/element_animations.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 
@@ skipping 141 matching lines @@
   // Update impl client state.
   if (needs_update_impl_client_state_)
     element_animations_impl->UpdateClientAnimationState();
   needs_update_impl_client_state_ = false;
 
   element_animations_impl->UpdateActivation(ActivationType::NORMAL);
 }
 
 void ElementAnimations::Animate(base::TimeTicks monotonic_time) {
   DCHECK(!monotonic_time.is_null());
-  if (!has_element_in_active_list() && !has_element_in_pending_list())
+  if (!has_element_in_active_list() && !has_element_in_pending_list()) {
+    animation_host_->DidDeactivateElementAnimations(this);

[loyso (OOO), 2016/11/27 23:36:55]

if you call host_->UnregisterElement, ElementAnimations::ElementUnregistered
should be called. I belive, DidDeactivate is called in
ElementAnimations::ElementUnregistered for the main thread.

For the impl thread: On PushProperties, ElementAnimations::UpdateActivation is
called.

It looks like we need to fix ElementAnimations::UpdateActivation (add the
has_element_in_any_list() check there). ::UpdateActivation is the actual
command, ::Animate is a regular general tick.

What do you think?

[junchao.han, 2016/11/28 04:09:03]

Thanks for the comments. Not DidActivateElementAnimations in PushProperties is a
better way than DidDeactivateElementAnimations in the general tick. A new patch
has been upload and PTAL. The new patch checks has_element_in_any_list in
UpdateActivation. However this patch will cause following two cc_unittests
failed. I will take a look.

LayerTreeHostAnimationTestAnimatedLayerRemovedAndAdded.RunMultiThread_DelegatingRenderer
LayerTreeHostAnimationTestAnimatedLayerRemovedAndAdded.RunSingleThread_DelegatingRenderer

     return;
+  }
 
   for (auto& player : players_list_) {
     if (player.needs_to_start_animations())
       player.StartAnimations(monotonic_time);
   }
 
   for (auto& player : players_list_)
     player.TickAnimations(monotonic_time);
 
   last_tick_time_ = monotonic_time;
@@ skipping 392 matching lines @@
   if (animation_host()) {
     DCHECK(animation_host()->mutator_host_client());
     return animation_host()->mutator_host_client()->GetScrollOffsetForAnimation(
         element_id());
   }
 
   return gfx::ScrollOffset();
 }
 
 }  // namespace cc