|
|
DescriptionRoll pdfium/build/ dc8cb2c8b..acf607f7d (79 commits).
https://chromium.googlesource.com/chromium/src/build.git/+log/dc8cb2c8bcc3..acf607f7d345
R=thestig@chromium.org,dsinclair@chromium.org
BUG=pdfium:415
Committed: https://pdfium.googlesource.com/pdfium/+/841a85b19cc10d719505ea2c7e0e49bae843db6e
Patch Set 1 #Patch Set 2 : +use_system_xcode #Messages
Total messages: 25 (15 generated)
Description was changed from ========== Roll pdfium/build/ dc8cb2c8b..acf607f7d (79 commits). https://chromium.googlesource.com/chromium/src/build.git/+log/dc8cb2c8bcc3..a... $ git log dc8cb2c8b..acf607f7d --date=short --no-merges --format='%ad %ae %s' 2016-11-23 dgn Add dependency on the Google Play services Vision API 2016-11-23 scottmg Enable /utf-8 on Windows 2016-11-23 thakis posix: Pass -Werror to the compiler driver for link invocations as well. 2016-11-23 kthelgason Reland of move unused build override (patchset #1 id:1 of https://codereview.chromium.org/2520383002/ ) 2016-11-22 megjablon Change the Data Saver infobar promo icon to blue 2016-11-22 bpastene Add .jar files to timestamp zapping in remove_build_metadata.py 2016-11-22 dpranke Change GN to disallow reading args defined in the same declare_args() call. 2016-11-22 rnk Use /OPT:REF in clang static release builds 2016-11-22 mikecase Make platform-mode default for JUnit tests. 2016-11-22 brettw Move enable_webrtc to a buildflag header. 2016-11-22 scottmg Strip invalid utf-8 characters from mc.exe header output 2016-11-22 thomasanderson Upload new Jessie sysroots 2016-11-22 sigbjornf Enable precompiled headers for Blink on Windows. 2016-11-21 thakis chrome/android/intel/clang: Use --icf=safe instead of --icf=all. 2016-11-21 dpranke Move the GN exec_script whitelist for //build into //build. 2016-11-21 scottmg win: Delete the pdb before linking an exe for official 2016-11-21 milko.leporis Fix Jessie sysroot missing deps 2016-11-21 cwallez Allow GLES2 conform to use GTK2 2016-11-21 bpastene Fix logdog typo in android's logdog_wrapper.py 2016-11-21 zpeng Reland #2 of Add GN build rules to allow java_assertion_enabler to enable Java asserts. 2016-11-21 michaelbai Pass deps to emma_instr target 2016-11-21 brettw Clean up GTK3 build flags. 2016-11-21 jbudorick [Android] Fix generated junit scripts wrt --runtime-deps-file. 2016-11-21 anthonyvd Revert of Add check_build_deps step to gclient runhooks (patchset #2 id:20001 of https://codereview.chromium.org/2505413003/ ) 2016-11-21 jack Add IPA Fonts to install-build-deps.*. 2016-11-21 thomasanderson Add check_build_deps step to gclient runhooks 2016-11-19 brettw Move enable_wifi_display out of root build configuration. 2016-11-19 brettw Convert enable_plugins to a buildflag header. 2016-11-18 thomasanderson Fix install-build-deps.sh --quick-check 2016-11-18 jbudorick [android] Stop using isolate.py for data dependency management. (RELAND) 2016-11-18 mikecase Fix KeyError caused when filtering gtests on multiple threads. 2016-11-18 jbudorick Reland of [Android] Make the test runner terminate gracefully on SIGTERM. (patchset #1 id:1 of https://codereview.chromium.org/2511243005/ ) 2016-11-18 fsamuel Revert of [Android] Make the test runner terminate gracefully on SIGTERM. (patchset #2 id:20001 of https://codereview.chromium.org/2511733004/ ) 2016-11-18 brettw Move use_xkbcommon from build to ui/base 2016-11-18 jbudorick [Android] Make the test runner terminate gracefully on SIGTERM. 2016-11-18 sdefresne Cleanup ios_xctest_test template. 2016-11-17 sbc Disable thumb when building tcmalloc 2016-11-17 jbudorick Revert of [android] Stop using isolate.py for data dependency management. (patchset #9 id:160001 of https://codereview.chromium.org/2492123002/ ) 2016-11-17 jbudorick [android] Stop using isolate.py for data dependency management. 2016-11-16 yolandyan Revert of Add GN build rules to allow java_assertion_enabler to enable Java asserts. (patchset #2 id:140001 of https://codereview.chromium.org/2506013004/ ) 2016-11-16 eroman Kill any lingering spawning test server on Android when handling /start 2016-11-16 bshe Reland of Enable WebVR for non component build (patchset #1 id:1 of https://codereview.chromium.org/2505963003/ ) 2016-11-16 mikecase Switch monkey test to platform mode. 2016-11-16 estevenson Add support for single line enums to java_cpp_enum.py. 2016-11-16 agrieve generate_gradle.py: Add support for junit and java_binary targets 2016-11-16 zpeng Reland of Add GN build rules to allow java_assertion_enabler to enable Java asserts. 2016-11-16 agrieve Revert of Enable WebVR for non component build (patchset #5 id:80001 of https://codereview.chromium.org/2502643002/ ) 2016-11-16 agrieve Remove now-renamed java targets 2016-11-16 bpastene Check for existence of logdog binary and logcat source before uploading. 2016-11-16 justincohen Remove public-read flag for hermetic build uploads. 2016-11-16 zpeng Revert of Add GN build rules to allow java_assertion_enabler to enable Java asserts. (patchset #4 id:60001 of https://codereview.chromium.org/2497043002/ ) 2016-11-16 estevenson Update error message in java_cpp_enum.py. 2016-11-16 agrieve generate_gradle.py: Build all generated files (not just .srcjars) 2016-11-16 zpeng Add GN build rules to allow java_assertion_enabler to enable Java asserts. 2016-11-16 brettw Move json_schema_api.gni to tools/json_schema_compiler/ 2016-11-16 estevenson Fix comment preservation in java_cpp_enum.py. 2016-11-16 bshe Enable Android WebVR for arm & arm64 2016-11-15 horo Revert of Replace kochi-*.ttf with IPA Fonts. (patchset #3 id:40001 of https://codereview.chromium.org/2500063003/ ) 2016-11-15 jack Replace kochi-*.ttf with IPA Fonts. 2016-11-14 hzl Add options for store-tombstones for gtest. 2016-11-14 agrieve Bump default_lint_android_sdk_version to 24 to match sdk 2016-11-14 brettw Remove some global UI defines 2016-11-14 estevenson Fix inputs for main_dex_list action. 2016-11-14 brucedawson Make /fastlink builds as optimized as non-/fastlink builds 2016-11-14 agrieve Fix java target naming exceptions in third_party/ 2016-11-14 brettw Convert spellcheck to a buildflag header. 2016-11-14 jbudorick [Android] Fix instrumentation test filtering for parameterized tests. 2016-11-13 kjellander Move use_system_xcode to //build_overrides/build.gni 2016-11-11 brettw Move enable extensions define to a build flag. 2016-11-11 mikecase Add support for Junit tests in platform mode. 2016-11-11 bshe Linking arm and arm64 gvr static shim library. 2016-11-11 brettw Remove some global defines and build flags. 2016-11-11 brettw Move use_brlapi build flag to chrome. 2016-11-11 jbudorick [android] Tweak data deps to include two chromium tool binaries. (RELAND) 2016-11-11 thakis adb_gdb: Successfully find toolchain for --target-arch=x86_64. 2016-11-11 thakis adb_gdb: Don't require adb to be on PATH. 2016-11-11 tobiasjs Revert of [android] Tweak data deps to include two chromium tool binaries. (patchset #2 id:20001 of https://codereview.chromium.org/2488013003/ ) 2016-11-10 xingliu Setup Blimp internal string resources. 2016-11-10 sdefresne Remove support for old naming convention for EarlGrey tests on iOS. R=thestig@chromium.org BUG=pdfium:415 ========== to ========== Roll pdfium/build/ dc8cb2c8b..acf607f7d (79 commits). https://chromium.googlesource.com/chromium/src/build.git/+log/dc8cb2c8bcc3..a... $ git log dc8cb2c8b..acf607f7d --date=short --no-merges --format='%ad %ae %s' 2016-11-23 dgn Add dependency on the Google Play services Vision API 2016-11-23 scottmg Enable /utf-8 on Windows 2016-11-23 thakis posix: Pass -Werror to the compiler driver for link invocations as well. 2016-11-23 kthelgason Reland of move unused build override (patchset #1 id:1 of https://codereview.chromium.org/2520383002/ ) 2016-11-22 megjablon Change the Data Saver infobar promo icon to blue 2016-11-22 bpastene Add .jar files to timestamp zapping in remove_build_metadata.py 2016-11-22 dpranke Change GN to disallow reading args defined in the same declare_args() call. 2016-11-22 rnk Use /OPT:REF in clang static release builds 2016-11-22 mikecase Make platform-mode default for JUnit tests. 2016-11-22 brettw Move enable_webrtc to a buildflag header. 2016-11-22 scottmg Strip invalid utf-8 characters from mc.exe header output 2016-11-22 thomasanderson Upload new Jessie sysroots 2016-11-22 sigbjornf Enable precompiled headers for Blink on Windows. 2016-11-21 thakis chrome/android/intel/clang: Use --icf=safe instead of --icf=all. 2016-11-21 dpranke Move the GN exec_script whitelist for //build into //build. 2016-11-21 scottmg win: Delete the pdb before linking an exe for official 2016-11-21 milko.leporis Fix Jessie sysroot missing deps 2016-11-21 cwallez Allow GLES2 conform to use GTK2 2016-11-21 bpastene Fix logdog typo in android's logdog_wrapper.py 2016-11-21 zpeng Reland #2 of Add GN build rules to allow java_assertion_enabler to enable Java asserts. 2016-11-21 michaelbai Pass deps to emma_instr target 2016-11-21 brettw Clean up GTK3 build flags. 2016-11-21 jbudorick [Android] Fix generated junit scripts wrt --runtime-deps-file. 2016-11-21 anthonyvd Revert of Add check_build_deps step to gclient runhooks (patchset #2 id:20001 of https://codereview.chromium.org/2505413003/ ) 2016-11-21 jack Add IPA Fonts to install-build-deps.*. 2016-11-21 thomasanderson Add check_build_deps step to gclient runhooks 2016-11-19 brettw Move enable_wifi_display out of root build configuration. 2016-11-19 brettw Convert enable_plugins to a buildflag header. 2016-11-18 thomasanderson Fix install-build-deps.sh --quick-check 2016-11-18 jbudorick [android] Stop using isolate.py for data dependency management. (RELAND) 2016-11-18 mikecase Fix KeyError caused when filtering gtests on multiple threads. 2016-11-18 jbudorick Reland of [Android] Make the test runner terminate gracefully on SIGTERM. (patchset #1 id:1 of https://codereview.chromium.org/2511243005/ ) 2016-11-18 fsamuel Revert of [Android] Make the test runner terminate gracefully on SIGTERM. (patchset #2 id:20001 of https://codereview.chromium.org/2511733004/ ) 2016-11-18 brettw Move use_xkbcommon from build to ui/base 2016-11-18 jbudorick [Android] Make the test runner terminate gracefully on SIGTERM. 2016-11-18 sdefresne Cleanup ios_xctest_test template. 2016-11-17 sbc Disable thumb when building tcmalloc 2016-11-17 jbudorick Revert of [android] Stop using isolate.py for data dependency management. (patchset #9 id:160001 of https://codereview.chromium.org/2492123002/ ) 2016-11-17 jbudorick [android] Stop using isolate.py for data dependency management. 2016-11-16 yolandyan Revert of Add GN build rules to allow java_assertion_enabler to enable Java asserts. (patchset #2 id:140001 of https://codereview.chromium.org/2506013004/ ) 2016-11-16 eroman Kill any lingering spawning test server on Android when handling /start 2016-11-16 bshe Reland of Enable WebVR for non component build (patchset #1 id:1 of https://codereview.chromium.org/2505963003/ ) 2016-11-16 mikecase Switch monkey test to platform mode. 2016-11-16 estevenson Add support for single line enums to java_cpp_enum.py. 2016-11-16 agrieve generate_gradle.py: Add support for junit and java_binary targets 2016-11-16 zpeng Reland of Add GN build rules to allow java_assertion_enabler to enable Java asserts. 2016-11-16 agrieve Revert of Enable WebVR for non component build (patchset #5 id:80001 of https://codereview.chromium.org/2502643002/ ) 2016-11-16 agrieve Remove now-renamed java targets 2016-11-16 bpastene Check for existence of logdog binary and logcat source before uploading. 2016-11-16 justincohen Remove public-read flag for hermetic build uploads. 2016-11-16 zpeng Revert of Add GN build rules to allow java_assertion_enabler to enable Java asserts. (patchset #4 id:60001 of https://codereview.chromium.org/2497043002/ ) 2016-11-16 estevenson Update error message in java_cpp_enum.py. 2016-11-16 agrieve generate_gradle.py: Build all generated files (not just .srcjars) 2016-11-16 zpeng Add GN build rules to allow java_assertion_enabler to enable Java asserts. 2016-11-16 brettw Move json_schema_api.gni to tools/json_schema_compiler/ 2016-11-16 estevenson Fix comment preservation in java_cpp_enum.py. 2016-11-16 bshe Enable Android WebVR for arm & arm64 2016-11-15 horo Revert of Replace kochi-*.ttf with IPA Fonts. (patchset #3 id:40001 of https://codereview.chromium.org/2500063003/ ) 2016-11-15 jack Replace kochi-*.ttf with IPA Fonts. 2016-11-14 hzl Add options for store-tombstones for gtest. 2016-11-14 agrieve Bump default_lint_android_sdk_version to 24 to match sdk 2016-11-14 brettw Remove some global UI defines 2016-11-14 estevenson Fix inputs for main_dex_list action. 2016-11-14 brucedawson Make /fastlink builds as optimized as non-/fastlink builds 2016-11-14 agrieve Fix java target naming exceptions in third_party/ 2016-11-14 brettw Convert spellcheck to a buildflag header. 2016-11-14 jbudorick [Android] Fix instrumentation test filtering for parameterized tests. 2016-11-13 kjellander Move use_system_xcode to //build_overrides/build.gni 2016-11-11 brettw Move enable extensions define to a build flag. 2016-11-11 mikecase Add support for Junit tests in platform mode. 2016-11-11 bshe Linking arm and arm64 gvr static shim library. 2016-11-11 brettw Remove some global defines and build flags. 2016-11-11 brettw Move use_brlapi build flag to chrome. 2016-11-11 jbudorick [android] Tweak data deps to include two chromium tool binaries. (RELAND) 2016-11-11 thakis adb_gdb: Successfully find toolchain for --target-arch=x86_64. 2016-11-11 thakis adb_gdb: Don't require adb to be on PATH. 2016-11-11 tobiasjs Revert of [android] Tweak data deps to include two chromium tool binaries. (patchset #2 id:20001 of https://codereview.chromium.org/2488013003/ ) 2016-11-10 xingliu Setup Blimp internal string resources. 2016-11-10 sdefresne Remove support for old naming convention for EarlGrey tests on iOS. R=thestig@chromium.org,dsinclair@chromium.org BUG=pdfium:415 ==========
jbudorick@chromium.org changed reviewers: + dsinclair@chromium.org
Picking up the data dependency management changes for running tests on android.
The CQ bit was checked by thestig@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
I kicked off trybots. lgtm with green bots. I usually don't list out the individual commits in PDFium's DEPS rolls. It's usually way too long.
thestig@chromium.org changed reviewers: + dpranke@chromium.org
and red bots = not lgtm +dpranke too
On 2016/11/23 19:59:36, Lei Zhang (Mostly OOO) wrote: > I kicked off trybots. lgtm with green bots. > > I usually don't list out the individual commits in PDFium's DEPS rolls. It's > usually way too long. I can pull the commit list out if you'd like; I just used roll-dep.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac on master.tryserver.client.pdfium (JOB_FAILED, https://build.chromium.org/p/tryserver.client.pdfium/builders/mac/builds/2968)
On 2016/11/23 20:00:14, Lei Zhang (Mostly OOO) wrote: > and red bots = not lgtm Seems like mac gn is unhappy. > > +dpranke too
On 2016/11/23 20:01:59, jbudorick wrote: > On 2016/11/23 20:00:14, Lei Zhang (Mostly OOO) wrote: > > and red bots = not lgtm > > Seems like mac gn is unhappy. > > > > > +dpranke too You need to update //build_overrides/build.gni to add a use_system_xcode arg.
The CQ bit was checked by jbudorick@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Roll pdfium/build/ dc8cb2c8b..acf607f7d (79 commits). https://chromium.googlesource.com/chromium/src/build.git/+log/dc8cb2c8bcc3..a... $ git log dc8cb2c8b..acf607f7d --date=short --no-merges --format='%ad %ae %s' 2016-11-23 dgn Add dependency on the Google Play services Vision API 2016-11-23 scottmg Enable /utf-8 on Windows 2016-11-23 thakis posix: Pass -Werror to the compiler driver for link invocations as well. 2016-11-23 kthelgason Reland of move unused build override (patchset #1 id:1 of https://codereview.chromium.org/2520383002/ ) 2016-11-22 megjablon Change the Data Saver infobar promo icon to blue 2016-11-22 bpastene Add .jar files to timestamp zapping in remove_build_metadata.py 2016-11-22 dpranke Change GN to disallow reading args defined in the same declare_args() call. 2016-11-22 rnk Use /OPT:REF in clang static release builds 2016-11-22 mikecase Make platform-mode default for JUnit tests. 2016-11-22 brettw Move enable_webrtc to a buildflag header. 2016-11-22 scottmg Strip invalid utf-8 characters from mc.exe header output 2016-11-22 thomasanderson Upload new Jessie sysroots 2016-11-22 sigbjornf Enable precompiled headers for Blink on Windows. 2016-11-21 thakis chrome/android/intel/clang: Use --icf=safe instead of --icf=all. 2016-11-21 dpranke Move the GN exec_script whitelist for //build into //build. 2016-11-21 scottmg win: Delete the pdb before linking an exe for official 2016-11-21 milko.leporis Fix Jessie sysroot missing deps 2016-11-21 cwallez Allow GLES2 conform to use GTK2 2016-11-21 bpastene Fix logdog typo in android's logdog_wrapper.py 2016-11-21 zpeng Reland #2 of Add GN build rules to allow java_assertion_enabler to enable Java asserts. 2016-11-21 michaelbai Pass deps to emma_instr target 2016-11-21 brettw Clean up GTK3 build flags. 2016-11-21 jbudorick [Android] Fix generated junit scripts wrt --runtime-deps-file. 2016-11-21 anthonyvd Revert of Add check_build_deps step to gclient runhooks (patchset #2 id:20001 of https://codereview.chromium.org/2505413003/ ) 2016-11-21 jack Add IPA Fonts to install-build-deps.*. 2016-11-21 thomasanderson Add check_build_deps step to gclient runhooks 2016-11-19 brettw Move enable_wifi_display out of root build configuration. 2016-11-19 brettw Convert enable_plugins to a buildflag header. 2016-11-18 thomasanderson Fix install-build-deps.sh --quick-check 2016-11-18 jbudorick [android] Stop using isolate.py for data dependency management. (RELAND) 2016-11-18 mikecase Fix KeyError caused when filtering gtests on multiple threads. 2016-11-18 jbudorick Reland of [Android] Make the test runner terminate gracefully on SIGTERM. (patchset #1 id:1 of https://codereview.chromium.org/2511243005/ ) 2016-11-18 fsamuel Revert of [Android] Make the test runner terminate gracefully on SIGTERM. (patchset #2 id:20001 of https://codereview.chromium.org/2511733004/ ) 2016-11-18 brettw Move use_xkbcommon from build to ui/base 2016-11-18 jbudorick [Android] Make the test runner terminate gracefully on SIGTERM. 2016-11-18 sdefresne Cleanup ios_xctest_test template. 2016-11-17 sbc Disable thumb when building tcmalloc 2016-11-17 jbudorick Revert of [android] Stop using isolate.py for data dependency management. (patchset #9 id:160001 of https://codereview.chromium.org/2492123002/ ) 2016-11-17 jbudorick [android] Stop using isolate.py for data dependency management. 2016-11-16 yolandyan Revert of Add GN build rules to allow java_assertion_enabler to enable Java asserts. (patchset #2 id:140001 of https://codereview.chromium.org/2506013004/ ) 2016-11-16 eroman Kill any lingering spawning test server on Android when handling /start 2016-11-16 bshe Reland of Enable WebVR for non component build (patchset #1 id:1 of https://codereview.chromium.org/2505963003/ ) 2016-11-16 mikecase Switch monkey test to platform mode. 2016-11-16 estevenson Add support for single line enums to java_cpp_enum.py. 2016-11-16 agrieve generate_gradle.py: Add support for junit and java_binary targets 2016-11-16 zpeng Reland of Add GN build rules to allow java_assertion_enabler to enable Java asserts. 2016-11-16 agrieve Revert of Enable WebVR for non component build (patchset #5 id:80001 of https://codereview.chromium.org/2502643002/ ) 2016-11-16 agrieve Remove now-renamed java targets 2016-11-16 bpastene Check for existence of logdog binary and logcat source before uploading. 2016-11-16 justincohen Remove public-read flag for hermetic build uploads. 2016-11-16 zpeng Revert of Add GN build rules to allow java_assertion_enabler to enable Java asserts. (patchset #4 id:60001 of https://codereview.chromium.org/2497043002/ ) 2016-11-16 estevenson Update error message in java_cpp_enum.py. 2016-11-16 agrieve generate_gradle.py: Build all generated files (not just .srcjars) 2016-11-16 zpeng Add GN build rules to allow java_assertion_enabler to enable Java asserts. 2016-11-16 brettw Move json_schema_api.gni to tools/json_schema_compiler/ 2016-11-16 estevenson Fix comment preservation in java_cpp_enum.py. 2016-11-16 bshe Enable Android WebVR for arm & arm64 2016-11-15 horo Revert of Replace kochi-*.ttf with IPA Fonts. (patchset #3 id:40001 of https://codereview.chromium.org/2500063003/ ) 2016-11-15 jack Replace kochi-*.ttf with IPA Fonts. 2016-11-14 hzl Add options for store-tombstones for gtest. 2016-11-14 agrieve Bump default_lint_android_sdk_version to 24 to match sdk 2016-11-14 brettw Remove some global UI defines 2016-11-14 estevenson Fix inputs for main_dex_list action. 2016-11-14 brucedawson Make /fastlink builds as optimized as non-/fastlink builds 2016-11-14 agrieve Fix java target naming exceptions in third_party/ 2016-11-14 brettw Convert spellcheck to a buildflag header. 2016-11-14 jbudorick [Android] Fix instrumentation test filtering for parameterized tests. 2016-11-13 kjellander Move use_system_xcode to //build_overrides/build.gni 2016-11-11 brettw Move enable extensions define to a build flag. 2016-11-11 mikecase Add support for Junit tests in platform mode. 2016-11-11 bshe Linking arm and arm64 gvr static shim library. 2016-11-11 brettw Remove some global defines and build flags. 2016-11-11 brettw Move use_brlapi build flag to chrome. 2016-11-11 jbudorick [android] Tweak data deps to include two chromium tool binaries. (RELAND) 2016-11-11 thakis adb_gdb: Successfully find toolchain for --target-arch=x86_64. 2016-11-11 thakis adb_gdb: Don't require adb to be on PATH. 2016-11-11 tobiasjs Revert of [android] Tweak data deps to include two chromium tool binaries. (patchset #2 id:20001 of https://codereview.chromium.org/2488013003/ ) 2016-11-10 xingliu Setup Blimp internal string resources. 2016-11-10 sdefresne Remove support for old naming convention for EarlGrey tests on iOS. R=thestig@chromium.org,dsinclair@chromium.org BUG=pdfium:415 ========== to ========== Roll pdfium/build/ dc8cb2c8b..acf607f7d (79 commits). https://chromium.googlesource.com/chromium/src/build.git/+log/dc8cb2c8bcc3..a... R=thestig@chromium.org,dsinclair@chromium.org BUG=pdfium:415 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Lifted the use_system_xcode logic from chromium's build_overrides + removed the commit list from the description. ptal
lgtm
The CQ bit was checked by thestig@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1479936783519140, "parent_rev": "7c47e1d3172ce6f625b93be50aac2ebf86a45d0c", "commit_rev": "841a85b19cc10d719505ea2c7e0e49bae843db6e"}
Message was sent while issue was closed.
Description was changed from ========== Roll pdfium/build/ dc8cb2c8b..acf607f7d (79 commits). https://chromium.googlesource.com/chromium/src/build.git/+log/dc8cb2c8bcc3..a... R=thestig@chromium.org,dsinclair@chromium.org BUG=pdfium:415 ========== to ========== Roll pdfium/build/ dc8cb2c8b..acf607f7d (79 commits). https://chromium.googlesource.com/chromium/src/build.git/+log/dc8cb2c8bcc3..a... R=thestig@chromium.org,dsinclair@chromium.org BUG=pdfium:415 Committed: https://pdfium.googlesource.com/pdfium/+/841a85b19cc10d719505ea2c7e0e49bae843... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://pdfium.googlesource.com/pdfium/+/841a85b19cc10d719505ea2c7e0e49bae843... |