Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 2527613003: Roll pdfium/build/ dc8cb2c8b..acf607f7d (79 commits). (Closed)

Created:
4 years ago by jbudorick
Modified:
4 years ago
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : +use_system_xcode #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M build_overrides/build.gni View 1 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (15 generated)
jbudorick
Picking up the data dependency management changes for running tests on android.
4 years ago (2016-11-23 19:54:17 UTC) #3
Lei Zhang
I kicked off trybots. lgtm with green bots. I usually don't list out the individual ...
4 years ago (2016-11-23 19:59:36 UTC) #6
Lei Zhang
and red bots = not lgtm +dpranke too
4 years ago (2016-11-23 20:00:14 UTC) #8
jbudorick
On 2016/11/23 19:59:36, Lei Zhang (Mostly OOO) wrote: > I kicked off trybots. lgtm with ...
4 years ago (2016-11-23 20:00:22 UTC) #9
jbudorick
On 2016/11/23 20:00:14, Lei Zhang (Mostly OOO) wrote: > and red bots = not lgtm ...
4 years ago (2016-11-23 20:01:59 UTC) #12
Dirk Pranke
On 2016/11/23 20:01:59, jbudorick wrote: > On 2016/11/23 20:00:14, Lei Zhang (Mostly OOO) wrote: > ...
4 years ago (2016-11-23 20:06:23 UTC) #13
jbudorick
Lifted the use_system_xcode logic from chromium's build_overrides + removed the commit list from the description. ...
4 years ago (2016-11-23 20:58:14 UTC) #19
Lei Zhang
lgtm
4 years ago (2016-11-23 21:32:33 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2527613003/20001
4 years ago (2016-11-23 21:33:15 UTC) #22
commit-bot: I haz the power
4 years ago (2016-11-23 21:33:36 UTC) #25
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/841a85b19cc10d719505ea2c7e0e49bae843...

Powered by Google App Engine
This is Rietveld 408576698