Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Issue 2500063003: Replace kochi-*.ttf with IPA Fonts. (Reland)

Created:
4 years, 1 month ago by Jack Bates
Modified:
3 years, 6 months ago
CC:
chromium-reviews, tonikitoo
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace kochi-*.ttf with IPA Fonts. (Reland) kochi-gothic.ttf and kochi-mincho.ttf were deprecated [1] and dropped from Debian and Ubuntu [2]. They were replaced with ipag.ttf and ipam.ttf (fonts-ipafont package). [1] https://packages.debian.org/wheezy/ttf-kochi-gothic [2] 726382 #33">https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=726382 #33 BUG=665515 Committed: https://crrev.com/a15698acc363af3e3b28543135e765019ef709a1 Cr-Commit-Position: refs/heads/master@{#432306}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Update install-build-deps.* #

Total comments: 2

Patch Set 3 : Reflow long line #

Patch Set 4 : fonts.conf #

Patch Set 5 : Rebase #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -13 lines) Patch
M build/experimental/install-build-deps.py View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M build/install-build-deps.sh View 1 2 3 4 1 chunk +0 lines, -8 lines 1 comment Download
M components/test_runner/resources/fonts/fonts.conf View 1 2 3 4 1 chunk +25 lines, -0 lines 0 comments Download
M docs/layout_tests_linux.md View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/test/fontconfig_util_linux.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 87 (42 generated)
Jack Bates
I picked Thomas Anderson to review this because of your work on issue 621695. Is ...
4 years, 1 month ago (2016-11-15 18:45:19 UTC) #3
Tom (Use chromium acct)
Hi jack@, unfortunately I don't have any OWNERS power here + some font folks from ...
4 years, 1 month ago (2016-11-15 19:04:34 UTC) #5
Daniel Erat
thanks! mind also updating build/install-build-deps.sh (and build/experimental/install-build-deps.py, i guess) to install the new package?
4 years, 1 month ago (2016-11-15 19:12:54 UTC) #6
msw
I'll leave review to Dan, here's more knowledgeable here. https://codereview.chromium.org/2500063003/diff/1/AUTHORS File AUTHORS (right): https://codereview.chromium.org/2500063003/diff/1/AUTHORS#newcode282 AUTHORS:282: ...
4 years, 1 month ago (2016-11-15 19:15:43 UTC) #9
Jack Bates
On 2016/11/15 19:12:54, Daniel Erat wrote: > thanks! mind also updating build/install-build-deps.sh (and > build/experimental/install-build-deps.py, ...
4 years, 1 month ago (2016-11-15 20:03:13 UTC) #12
Daniel Erat
https://codereview.chromium.org/2500063003/diff/20001/build/install-build-deps.sh File build/install-build-deps.sh (right): https://codereview.chromium.org/2500063003/diff/20001/build/install-build-deps.sh#newcode101 build/install-build-deps.sh:101: flex fonts-ipafont fonts-thai-tlwg g++ git-core git-svn gperf language-pack-da nit: ...
4 years, 1 month ago (2016-11-15 20:06:53 UTC) #13
Jack Bates
https://codereview.chromium.org/2500063003/diff/20001/build/install-build-deps.sh File build/install-build-deps.sh (right): https://codereview.chromium.org/2500063003/diff/20001/build/install-build-deps.sh#newcode101 build/install-build-deps.sh:101: flex fonts-ipafont fonts-thai-tlwg g++ git-core git-svn gperf language-pack-da On ...
4 years, 1 month ago (2016-11-15 20:14:38 UTC) #14
Daniel Erat
lgtm
4 years, 1 month ago (2016-11-15 20:38:50 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2500063003/40001
4 years, 1 month ago (2016-11-15 20:39:56 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/304696)
4 years, 1 month ago (2016-11-15 20:53:59 UTC) #19
Jack Bates
On 2016/11/15 19:15:43, msw wrote: > I'll leave review to Dan, here's more knowledgeable here. ...
4 years, 1 month ago (2016-11-15 21:56:26 UTC) #20
Daniel Erat
asvitkine@, mind reviewing for ui/gfx? i'll send an additional change to add myself as an ...
4 years, 1 month ago (2016-11-15 22:02:12 UTC) #22
Daniel Erat
(oh, or mike can rubber-stamp it for ui/gfx...)
4 years, 1 month ago (2016-11-15 22:04:36 UTC) #23
Nico
rs-lgtm everything
4 years, 1 month ago (2016-11-15 22:05:58 UTC) #24
msw
lgtm
4 years, 1 month ago (2016-11-15 22:09:22 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2500063003/40001
4 years, 1 month ago (2016-11-15 22:10:44 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/261177)
4 years, 1 month ago (2016-11-15 22:44:07 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2500063003/40001
4 years, 1 month ago (2016-11-15 23:05:20 UTC) #31
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/261322)
4 years, 1 month ago (2016-11-15 23:30:50 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2500063003/40001
4 years, 1 month ago (2016-11-15 23:51:46 UTC) #35
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-16 00:15:26 UTC) #37
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/a15698acc363af3e3b28543135e765019ef709a1 Cr-Commit-Position: refs/heads/master@{#432306}
4 years, 1 month ago (2016-11-16 00:17:49 UTC) #39
horo
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2504863002/ by horo@chromium.org. ...
4 years, 1 month ago (2016-11-16 03:41:41 UTC) #40
Jack Bates
On 2016/11/16 03:41:41, horo (JP-TOK sheriff Nov15-16) wrote: > A revert of this CL (patchset ...
4 years, 1 month ago (2016-11-16 20:54:58 UTC) #41
Daniel Erat
On 2016/11/16 20:54:58, Jack Bates wrote: > On 2016/11/16 03:41:41, horo (JP-TOK sheriff Nov15-16) wrote: ...
4 years, 1 month ago (2016-11-16 21:26:40 UTC) #42
Jack Bates
On 2016/11/16 21:26:40, Daniel Erat wrote: > On 2016/11/16 20:54:58, Jack Bates wrote: > > ...
4 years, 1 month ago (2016-11-18 16:46:50 UTC) #46
msw
I triggered that list of try bots for you, but I'm not familiar with this ...
4 years, 1 month ago (2016-11-18 17:32:51 UTC) #49
Daniel Erat
i've done the following: - patched your change into a ToT branch using "git cl ...
4 years, 1 month ago (2016-11-18 17:37:31 UTC) #50
Jack Bates
Thank you! I guess I can't rebaseline the tests until the fonts-ipafont package is added ...
4 years, 1 month ago (2016-11-18 19:18:11 UTC) #51
Daniel Erat
On 2016/11/18 19:18:11, Jack Bates wrote: > Thank you! > I guess I can't rebaseline ...
4 years, 1 month ago (2016-11-18 19:20:54 UTC) #52
Jack Bates
On 2016/11/18 19:20:54, Daniel Erat wrote: > On 2016/11/18 19:18:11, Jack Bates wrote: > > ...
4 years, 1 month ago (2016-11-19 15:54:24 UTC) #61
Daniel Erat
On 2016/11/19 15:54:24, Jack Bates wrote: > On 2016/11/18 19:20:54, Daniel Erat wrote: > > ...
4 years, 1 month ago (2016-11-19 16:01:27 UTC) #62
Jack Bates
On 2016/11/19 16:01:27, Daniel Erat wrote: > On 2016/11/19 15:54:24, Jack Bates wrote: > > ...
4 years, 1 month ago (2016-11-19 16:05:57 UTC) #63
Jack Bates
On 2016/11/19 16:05:57, Jack Bates wrote: > On 2016/11/19 16:01:27, Daniel Erat wrote: > > ...
4 years ago (2016-12-13 21:49:33 UTC) #66
Daniel Erat
sure, but i think you need to sync your source tree and resolve a merge ...
4 years ago (2016-12-13 23:25:33 UTC) #67
Jack Bates
On 2016/12/13 23:25:33, Daniel Erat wrote: > sure, but i think you need to sync ...
4 years ago (2016-12-14 02:47:08 UTC) #68
Daniel Erat
On 2016/12/14 02:47:08, Jack Bates wrote: > On 2016/12/13 23:25:33, Daniel Erat wrote: > > ...
4 years ago (2016-12-14 05:42:33 UTC) #73
Jack Bates
On 2016/12/14 05:42:33, Daniel Erat wrote: > On 2016/12/14 02:47:08, Jack Bates wrote: > > ...
4 years ago (2016-12-14 15:27:11 UTC) #75
Dirk Pranke
rs- lgtm also.
4 years ago (2016-12-15 03:09:29 UTC) #76
Tom (Use chromium acct)
Is this safe to land now?
4 years ago (2016-12-21 02:01:29 UTC) #77
Jack Bates
On 2016/12/21 02:01:29, Tom Anderson wrote: > Is this safe to land now? I'm investigating ...
4 years ago (2016-12-21 17:01:23 UTC) #78
Dirk Pranke
Apparently I wasn't paying attention at all when I first looked at this. 1) So, ...
4 years ago (2016-12-21 18:30:40 UTC) #79
Jack Bates
On 2016/12/21 18:30:40, Dirk Pranke wrote: > Apparently I wasn't paying attention at all when ...
4 years ago (2016-12-21 18:42:34 UTC) #80
Dirk Pranke
Sounds great! Having just hit this problem on a Xenial instance, I look forward to ...
4 years ago (2016-12-21 18:43:14 UTC) #81
Tom (Use chromium acct)
3 years, 8 months ago (2017-04-14 18:55:42 UTC) #82
https://codereview.chromium.org/2500063003/diff/80001/build/install-build-dep...
File build/install-build-deps.sh (right):

https://codereview.chromium.org/2500063003/diff/80001/build/install-build-dep...
build/install-build-deps.sh:336: fi
Please add "fonts-ipafont" somewhere in this file.

Then, I can reference this CL and get infra labs to install it on all bots. 
Then we can finally land this (and hopefully not break the CQ this time).

Powered by Google App Engine
This is Rietveld 408576698