Refactor remove methods, add DCHECKS, and remove_observer boolean

Refactor remove methods, add DCHECKS, and remove_observer boolean

This CL addresses 5 minor things:
- Reorganize methods so we have methods for windows followed by widgets followed by views.
- Removing nodes and removing subtrees separated into different methods
- Added multiple DCHECKS
- Added |remove_observer| boolean to all Remove* methods so that we can
avoid situations where we remove an observer and add it back again
in the same callback. This could cause the callback to be called
endlessly. |remove_obsever| is false whenever we know we will add
back the nodes again.
- Added methods for removing view subtrees

BUG=648701
Committed: https://crrev.com/2349585314f727a4aba3cf37680fe4dab999a044
Cr-Commit-Position: refs/heads/master@{#434567}

[Sarmad Hashmi, 2016-11-23 03:34:41]

Description was changed from

==========
Refactor remove methods, add DCHECKS, and remove_observer boolean

This CL addresses 3 minor things:
- Removing nodes and removing subtrees separated into different methods
- Added multiple DCHECKS
- Added |remove_observer| boolean to all Remove* methods so that we can
avoid situations where we remove an observer and add it back again
in the same callback. This could cause the callback to be called
endlessly. |remove_obsever| is false whenever we know we will add
back the nodes again.

BUG=648701
==========

to

==========
Refactor remove methods, add DCHECKS, and remove_observer boolean

This CL addresses 4 minor things:
- Reorganize methods so we have methods for windows followed by widgets followed
by views.
- Removing nodes and removing subtrees separated into different methods
- Added multiple DCHECKS
- Added |remove_observer| boolean to all Remove* methods so that we can
avoid situations where we remove an observer and add it back again
in the same callback. This could cause the callback to be called
endlessly. |remove_obsever| is false whenever we know we will add
back the nodes again.

BUG=648701
==========

[Sarmad Hashmi, 2016-11-23 03:36:02]

Description was changed from

==========
Refactor remove methods, add DCHECKS, and remove_observer boolean

This CL addresses 4 minor things:
- Reorganize methods so we have methods for windows followed by widgets followed
by views.
- Removing nodes and removing subtrees separated into different methods
- Added multiple DCHECKS
- Added |remove_observer| boolean to all Remove* methods so that we can
avoid situations where we remove an observer and add it back again
in the same callback. This could cause the callback to be called
endlessly. |remove_obsever| is false whenever we know we will add
back the nodes again.

BUG=648701
==========

to

==========
Refactor remove methods, add DCHECKS, and remove_observer boolean

This CL addresses 5 minor things:
- Reorganize methods so we have methods for windows followed by widgets followed
by views.
- Removing nodes and removing subtrees separated into different methods
- Added multiple DCHECKS
- Added |remove_observer| boolean to all Remove* methods so that we can
avoid situations where we remove an observer and add it back again
in the same callback. This could cause the callback to be called
endlessly. |remove_obsever| is false whenever we know we will add
back the nodes again.
- Added methods for removing view subtrees

BUG=648701
==========

[Sarmad Hashmi, 2016-11-23 03:36:12]

The CQ bit was checked by mhashmi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 03:36:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 04:54:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 04:54:07]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Sarmad Hashmi, 2016-11-23 04:57:33]

mhashmi@chromium.org changed reviewers:
+ sadrul@chromium.org

[Sarmad Hashmi, 2016-11-23 04:57:34]

Please do let me know if I should split this up. Just a few minor things.

[sadrul, 2016-11-25 18:19:20]

lgtm

https://codereview.chromium.org/2527573003/diff/1/ash/common/devtools/ash_dev...
File ash/common/devtools/ash_devtools_dom_agent.cc (right):

https://codereview.chromium.org/2527573003/diff/1/ash/common/devtools/ash_dev...
ash/common/devtools/ash_devtools_dom_agent.cc:79: // DOM::Backend implementation
Remove these comments.

[Sarmad Hashmi, 2016-11-25 23:07:53]

The CQ bit was checked by mhashmi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-25 23:08:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sarmad Hashmi, 2016-11-25 23:27:30]

https://codereview.chromium.org/2527573003/diff/1/ash/common/devtools/ash_dev...
File ash/common/devtools/ash_devtools_dom_agent.cc (right):

https://codereview.chromium.org/2527573003/diff/1/ash/common/devtools/ash_dev...
ash/common/devtools/ash_devtools_dom_agent.cc:79: // DOM::Backend implementation
On 2016/11/25 18:19:20, sadrul wrote:
> Remove these comments.

Done.

[commit-bot: I haz the power, 2016-11-25 23:42:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-25 23:42:02]

Dry run: This issue passed the CQ dry run.

[Sarmad Hashmi, 2016-11-26 04:07:40]

The CQ bit was checked by mhashmi@chromium.org

[Sarmad Hashmi, 2016-11-26 04:07:40]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/2527573003/#ps20001
(title: "sadruls comments")

[commit-bot: I haz the power, 2016-11-26 04:07:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-26 04:13:23]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480133260321850,
"parent_rev": "59e1a5066fac2810dbdee965ad3798b6394617c4", "commit_rev":
"e63c66519c47fa45b9ec1409d444b23fda519caa"}

[commit-bot: I haz the power, 2016-11-26 04:14:23]

Description was changed from

==========
Refactor remove methods, add DCHECKS, and remove_observer boolean

This CL addresses 5 minor things:
- Reorganize methods so we have methods for windows followed by widgets followed
by views.
- Removing nodes and removing subtrees separated into different methods
- Added multiple DCHECKS
- Added |remove_observer| boolean to all Remove* methods so that we can
avoid situations where we remove an observer and add it back again
in the same callback. This could cause the callback to be called
endlessly. |remove_obsever| is false whenever we know we will add
back the nodes again.
- Added methods for removing view subtrees

BUG=648701
==========

to

==========
Refactor remove methods, add DCHECKS, and remove_observer boolean

This CL addresses 5 minor things:
- Reorganize methods so we have methods for windows followed by widgets followed
by views.
- Removing nodes and removing subtrees separated into different methods
- Added multiple DCHECKS
- Added |remove_observer| boolean to all Remove* methods so that we can
avoid situations where we remove an observer and add it back again
in the same callback. This could cause the callback to be called
endlessly. |remove_obsever| is false whenever we know we will add
back the nodes again.
- Added methods for removing view subtrees

BUG=648701
==========

[commit-bot: I haz the power, 2016-11-26 04:14:24]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-26 04:16:21]

Description was changed from

==========
Refactor remove methods, add DCHECKS, and remove_observer boolean

This CL addresses 5 minor things:
- Reorganize methods so we have methods for windows followed by widgets followed
by views.
- Removing nodes and removing subtrees separated into different methods
- Added multiple DCHECKS
- Added |remove_observer| boolean to all Remove* methods so that we can
avoid situations where we remove an observer and add it back again
in the same callback. This could cause the callback to be called
endlessly. |remove_obsever| is false whenever we know we will add
back the nodes again.
- Added methods for removing view subtrees

BUG=648701
==========

to

==========
Refactor remove methods, add DCHECKS, and remove_observer boolean

This CL addresses 5 minor things:
- Reorganize methods so we have methods for windows followed by widgets followed
by views.
- Removing nodes and removing subtrees separated into different methods
- Added multiple DCHECKS
- Added |remove_observer| boolean to all Remove* methods so that we can
avoid situations where we remove an observer and add it back again
in the same callback. This could cause the callback to be called
endlessly. |remove_obsever| is false whenever we know we will add
back the nodes again.
- Added methods for removing view subtrees

BUG=648701

Committed: https://crrev.com/2349585314f727a4aba3cf37680fe4dab999a044
Cr-Commit-Position: refs/heads/master@{#434567}
==========

[commit-bot: I haz the power, 2016-11-26 04:16:22]

Patchset 2 (id:??) landed as
https://crrev.com/2349585314f727a4aba3cf37680fe4dab999a044
Cr-Commit-Position: refs/heads/master@{#434567}