Add multifinger swipe event to TouchDispositionGestureFilter.

Add multifinger swipe event to TouchDispositionGestureFilter.

TEST=TouchDispositionGestureFilterTest.TestDisallowedMultiFingerSwipe

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266439

[tdresser, 2014-04-25 19:26:47]

jdduke, PTAL.

https://codereview.chromium.org/252753002/diff/1/ui/events/gesture_detection/...
File ui/events/gesture_detection/mock_motion_event.cc (right):

https://codereview.chromium.org/252753002/diff/1/ui/events/gesture_detection/...
ui/events/gesture_detection/mock_motion_event.cc:140: DCHECK_LT(pointer_count,
static_cast<size_t>(MAX_POINTERS));
I believe this was a bug, can you double check?

[jdduke (slow), 2014-04-25 19:38:55]

https://codereview.chromium.org/252753002/diff/1/ui/events/gesture_detection/...
File ui/events/gesture_detection/mock_motion_event.cc (right):

https://codereview.chromium.org/252753002/diff/1/ui/events/gesture_detection/...
ui/events/gesture_detection/mock_motion_event.cc:140: DCHECK_LT(pointer_count,
static_cast<size_t>(MAX_POINTERS));
On 2014/04/25 19:26:48, tdresser wrote:
> I believe this was a bug, can you double check?

It should be correct, note the |pointer_count++| call below (admittedly I'm not
proud of this code).

[tdresser, 2014-04-25 19:43:24]

https://codereview.chromium.org/252753002/diff/1/ui/events/gesture_detection/...
File ui/events/gesture_detection/mock_motion_event.cc (right):

https://codereview.chromium.org/252753002/diff/1/ui/events/gesture_detection/...
ui/events/gesture_detection/mock_motion_event.cc:140: DCHECK_LT(pointer_count,
static_cast<size_t>(MAX_POINTERS));
On 2014/04/25 19:38:55, jdduke wrote:
> On 2014/04/25 19:26:48, tdresser wrote:
> > I believe this was a bug, can you double check?
> 
> It should be correct, note the |pointer_count++| call below (admittedly I'm
not
> proud of this code).

So if I have 2 fingers down, and I press another finger, this currently
evaluates:

2 + 1 < 3 is false, and it doesn't let you press a third finger.
That's wrong, isn't it?

[jdduke (slow), 2014-04-25 19:45:25]

https://codereview.chromium.org/252753002/diff/1/ui/events/gesture_detection/...
File ui/events/gesture_detection/mock_motion_event.cc (right):

https://codereview.chromium.org/252753002/diff/1/ui/events/gesture_detection/...
ui/events/gesture_detection/mock_motion_event.cc:140: DCHECK_LT(pointer_count,
static_cast<size_t>(MAX_POINTERS));
On 2014/04/25 19:43:25, tdresser wrote:
> On 2014/04/25 19:38:55, jdduke wrote:
> > On 2014/04/25 19:26:48, tdresser wrote:
> > > I believe this was a bug, can you double check?
> > 
> > It should be correct, note the |pointer_count++| call below (admittedly I'm
> not
> > proud of this code).
> 
> So if I have 2 fingers down, and I press another finger, this currently
> evaluates:
> 
> 2 + 1 < 3 is false, and it doesn't let you press a third finger.
> That's wrong, isn't it?

It evaluates 2 < 3, then does the increment.

[jdduke (slow), 2014-04-25 19:46:58]

lgtm

https://codereview.chromium.org/252753002/diff/1/ui/events/gesture_detection/...
File ui/events/gesture_detection/mock_motion_event.cc (right):

https://codereview.chromium.org/252753002/diff/1/ui/events/gesture_detection/...
ui/events/gesture_detection/mock_motion_event.cc:140: DCHECK_LT(pointer_count,
static_cast<size_t>(MAX_POINTERS));
On 2014/04/25 19:45:26, jdduke wrote:
> On 2014/04/25 19:43:25, tdresser wrote:
> > On 2014/04/25 19:38:55, jdduke wrote:
> > > On 2014/04/25 19:26:48, tdresser wrote:
> > > > I believe this was a bug, can you double check?
> > > 
> > > It should be correct, note the |pointer_count++| call below (admittedly
I'm
> > not
> > > proud of this code).
> > 
> > So if I have 2 fingers down, and I press another finger, this currently
> > evaluates:
> > 
> > 2 + 1 < 3 is false, and it doesn't let you press a third finger.
> > That's wrong, isn't it?
> 
> It evaluates 2 < 3, then does the increment.

Ugg, lol yeah I was checking *your* code, not the current code.  Looks good.

[tdresser, 2014-04-25 19:47:50]

The CQ bit was checked by tdresser@chromium.org

[commit-bot: I haz the power, 2014-04-25 22:09:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tdresser@chromium.org/252753002/1

[commit-bot: I haz the power, 2014-04-25 23:39:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-25 23:39:56]

Try jobs failed on following builders:
  tryserver.chromium on win_chromium_rel

[tdresser, 2014-04-27 17:22:55]

The CQ bit was checked by tdresser@chromium.org

[commit-bot: I haz the power, 2014-04-27 17:23:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tdresser@chromium.org/252753002/1

[commit-bot: I haz the power, 2014-04-28 06:03:48]

Change committed as 266439