Add multifinger swipe event to TouchDispositionGestureFilter.

ui/events/gesture_detection/mock_motion_event.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/events/gesture_detection/mock_motion_event.h"
 
 #include "base/logging.h"
 
 using base::TimeTicks;
 
@@ skipping 119 matching lines @@
   cancel_event->action = MotionEvent::ACTION_CANCEL;
   return cancel_event.PassAs<MotionEvent>();
 }
 
 void MockMotionEvent::PressPoint(float x, float y) {
   // Reset the pointer count if the previously released and/or cancelled pointer
   // was the last pointer in the event.
   if (pointer_count == 1 && (action == ACTION_UP || action == ACTION_CANCEL))
     pointer_count = 0;
 
-  DCHECK_LT(pointer_count + 1, static_cast<size_t>(MAX_POINTERS));
+  DCHECK_LT(pointer_count, static_cast<size_t>(MAX_POINTERS));

[tdresser, 2014/04/25 19:26:48]

I believe this was a bug, can you double check?

[jdduke (slow), 2014/04/25 19:38:55]

It should be correct, note the |pointer_count++| call below (admittedly I'm not
proud of this code).

[tdresser, 2014/04/25 19:43:25]

So if I have 2 fingers down, and I press another finger, this currently
evaluates:

2 + 1 < 3 is false, and it doesn't let you press a third finger.
That's wrong, isn't it?

[jdduke (slow), 2014/04/25 19:45:26]

It evaluates 2 < 3, then does the increment.

[jdduke (slow), 2014/04/25 19:46:58]

Ugg, lol yeah I was checking *your* code, not the current code.  Looks good.

   points[pointer_count++] = gfx::PointF(x, y);
   action = pointer_count > 1 ? ACTION_POINTER_DOWN : ACTION_DOWN;
 }
 
 void MockMotionEvent::MovePoint(size_t index, float x, float y) {
   DCHECK_LT(index, pointer_count);
   points[index] = gfx::PointF(x, y);
   action = ACTION_MOVE;
 }
 
 void MockMotionEvent::ReleasePoint() {
   DCHECK_GT(pointer_count, 0U);
   if (pointer_count > 1) {
     --pointer_count;
     action = ACTION_POINTER_UP;
   } else {
     action = ACTION_UP;
   }
 }
 
 void MockMotionEvent::CancelPoint() {
   DCHECK_GT(pointer_count, 0U);
   if (pointer_count > 1)
     --pointer_count;
   action = ACTION_CANCEL;
 }
 
 }  // namespace ui