Issue 25275006: make vanilla android_ninja work, and add quiet options

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25275006: make vanilla android_ninja work, and add quiet options (Closed)

Created:
7 years, 2 months ago by mtklein

Modified:
7 years, 2 months ago

Reviewers:
borenet, djsollen

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

make vanilla android_ninja work, and add quiet options BUG= R=djsollen@google.com Committed: https://code.google.com/p/skia/source/detail?r=11540

Patch Set 2 : sync #

Total comments: 1

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -10 lines)			Patch
	M	platform_tools/android/bin/android_setup.sh	View		5 chunks	+14 lines, -8 lines	1 comment	Download
	M	platform_tools/android/gyp/skia_android.gypi	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

djsollen

lgtm, but I think the bots will want to export VERBOSE=1 so that we can ...

7 years, 2 months ago (2013-09-30 20:35:33 UTC) #2

borenet

https://codereview.chromium.org/25275006/diff/4001/platform_tools/android/bin/android_setup.sh File platform_tools/android/bin/android_setup.sh (right): https://codereview.chromium.org/25275006/diff/4001/platform_tools/android/bin/android_setup.sh#newcode30 platform_tools/android/bin/android_setup.sh:30: if [[ -n $VERBOSE ]]; then Could we rename ...

7 years, 2 months ago (2013-09-30 20:42:10 UTC) #3

mtklein

7 years, 2 months ago (2013-09-30 20:42:14 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r11540 (presubmit successful).

Expand Messages | Collapse Messages

Issue 25275006: make vanilla android_ninja work, and add quiet options (Closed)

Description

Patch Set 1 #

Patch Set 2 : sync #

Messages