Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: platform_tools/android/bin/android_setup.sh

Issue 25275006: make vanilla android_ninja work, and add quiet options (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: sync Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | platform_tools/android/gyp/skia_android.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: platform_tools/android/bin/android_setup.sh
diff --git a/platform_tools/android/bin/android_setup.sh b/platform_tools/android/bin/android_setup.sh
index 0629c6a6e85110da768ef2bed9d5a3cb4d9739a1..e58faa8de0221316b4312df811f626af4e61b796 100755
--- a/platform_tools/android/bin/android_setup.sh
+++ b/platform_tools/android/bin/android_setup.sh
@@ -26,10 +26,16 @@ while (( "$#" )); do
shift
done
+function verbose {
+ if [[ -n $VERBOSE ]]; then
borenet 2013/09/30 20:42:10 Could we rename this variable so that it's clear w
+ echo $@
+ fi
+}
+
function exportVar {
NAME=$1
VALUE=$2
- echo export $NAME=\"$VALUE\"
+ verbose export $NAME=\"$VALUE\"
export $NAME="$VALUE"
}
@@ -81,13 +87,13 @@ setup_toolchain() {
TOOLCHAIN_DIR=${SCRIPT_DIR}/../toolchains
if [ $(uname) == "Linux" ]; then
- echo "Using Linux toolchain."
+ verbose "Using Linux toolchain."
TOOLCHAIN_TYPE=ndk-r$NDK_REV-$ANDROID_ARCH-linux_v$API_LEVEL
elif [ $(uname) == "Darwin" ]; then
- echo "Using Mac toolchain."
+ verbose "Using Mac toolchain."
TOOLCHAIN_TYPE=ndk-r$NDK_REV-$ANDROID_ARCH-mac_v$API_LEVEL
else
- echo "Could not automatically determine toolchain! Defaulting to Linux."
+ verbose "Could not automatically determine toolchain! Defaulting to Linux."
TOOLCHAIN_TYPE=ndk-r$NDK_REV-$ANDROID_ARCH-linux_v$API_LEVEL
fi
exportVar ANDROID_TOOLCHAIN ${TOOLCHAIN_DIR}/${TOOLCHAIN_TYPE}/bin
@@ -121,7 +127,7 @@ setup_toolchain() {
return 1;
fi
- echo "The build is targeting NDK API level $API_LEVEL for use on Android 4.0 (NDK Revision $NDK_REV) and above"
+ verbose "The build is targeting NDK API level $API_LEVEL for use on Android 4.0 (NDK Revision $NDK_REV) and above"
LS="/bin/ls" # Use directly to avoid any 'ls' alias that might be defined.
GCC=$($LS $ANDROID_TOOLCHAIN/*-gcc | head -n1)
@@ -163,10 +169,10 @@ setup_device() {
if [ -z "$TARGET_DEVICE" ]; then
if [ -f .android_config ]; then
TARGET_DEVICE=$(cat .android_config)
- echo "INFO: no target device was specified so using the device (${TARGET_DEVICE}) from the most recent build"
+ verbose "INFO: no target device was specified so using the device (${TARGET_DEVICE}) from the most recent build"
else
TARGET_DEVICE="arm_v7_thumb"
- echo "INFO: no target device type was specified so using the default '${TARGET_DEVICE}'"
+ verbose "INFO: no target device type was specified so using the default '${TARGET_DEVICE}'"
fi
fi
@@ -227,7 +233,7 @@ setup_device() {
;;
esac
- echo "The build is targeting the device: $TARGET_DEVICE"
+ verbose "The build is targeting the device: $TARGET_DEVICE"
export DEVICE_ID="$TARGET_DEVICE"
# Set up the toolchain.
« no previous file with comments | « no previous file | platform_tools/android/gyp/skia_android.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698