Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2527473004: [inspector] removed old v8_inspector::Channel API (Closed)

Created:
4 years ago by kozy
Modified:
4 years ago
Reviewers:
dgozman
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] removed old v8_inspector::Channel API BUG=chromium:350797 R=dgozman@chromium.org TBR=yangguo@chromium.org Committed: https://crrev.com/d385ed069bb7b3759b6237f380f8585f16674f39 Cr-Commit-Position: refs/heads/master@{#41371}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -21 lines) Patch
M include/v8-inspector.h View 1 chunk +2 lines, -8 lines 0 comments Download
M src/d8.cc View 1 chunk +8 lines, -7 lines 0 comments Download
M test/inspector/inspector-impl.cc View 1 chunk +7 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
kozy
Dmitry, please take a look.
4 years ago (2016-11-23 23:58:18 UTC) #1
dgozman
lgtm Please make sure this doesn't break any bots.
4 years ago (2016-11-29 18:35:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2527473004/1
4 years ago (2016-11-29 18:44:49 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 19:31:14 UTC) #9
commit-bot: I haz the power
4 years ago (2016-11-29 19:31:33 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d385ed069bb7b3759b6237f380f8585f16674f39
Cr-Commit-Position: refs/heads/master@{#41371}

Powered by Google App Engine
This is Rietveld 408576698