Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: include/v8-inspector.h

Issue 2527473004: [inspector] removed old v8_inspector::Channel API (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/d8.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8-inspector.h
diff --git a/include/v8-inspector.h b/include/v8-inspector.h
index c367451cbc6780115c86d54c2b3fa7fd30733d83..d0925adba0460c0812245eff99e50401572f73ed 100644
--- a/include/v8-inspector.h
+++ b/include/v8-inspector.h
@@ -248,15 +248,9 @@ class V8_EXPORT V8Inspector {
class V8_EXPORT Channel {
public:
virtual ~Channel() {}
- virtual void sendProtocolResponse(int callId, const StringView& message) {}
- virtual void sendProtocolNotification(const StringView& message) {}
virtual void sendResponse(int callId,
- std::unique_ptr<StringBuffer> message) {
- sendProtocolResponse(callId, message->string());
- }
- virtual void sendNotification(std::unique_ptr<StringBuffer> message) {
- sendProtocolNotification(message->string());
- }
+ std::unique_ptr<StringBuffer> message) = 0;
+ virtual void sendNotification(std::unique_ptr<StringBuffer> message) = 0;
virtual void flushProtocolNotifications() = 0;
};
virtual std::unique_ptr<V8InspectorSession> connect(
« no previous file with comments | « no previous file | src/d8.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698