Display Compositor: Allocate LocalFrameId in client.

Display Compositor: Towards allocating SurfaceIds in the client

Currently, SurfaceIds are allocated in Mus or in the browser process.
This CL takes us a few steps towards being able to allocate SurfaceIds
(in particular, the LocalFrameId component of the SurfaceId) in the
client.

1. MojoCompositorFrameSink::SubmitCompositorFrame is updated to take in
a LocalFrameId. Offscreen canvas and the mus client library is
updated to use this new signature.

2. GpuCompositorFrameSink is updated to assume new LocalFrameIds will
be allocated in the client instead.

BUG=664547, 627283
TBR=piman@chromium.org for new DEPS on surface_id_allocator.h
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Committed: https://crrev.com/e3d2888a771050099facf2b18c3d72b4922c9581
Cr-Commit-Position: refs/heads/master@{#434091}

[Fady Samuel, 2016-11-22 17:46:53]

Description was changed from

==========
Display Compositor: Allocate LocalFrameId in client.

BUG=
==========

to

==========
Display Compositor: Allocate LocalFrameId in client.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Fady Samuel, 2016-11-22 18:08:35]

Description was changed from

==========
Display Compositor: Allocate LocalFrameId in client.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Display Compositor: Towards allocating SurfaceIds in the client

Currently, SurfaceIds are allocated in Mus or in the browser process.
This CL takes us a few steps towards being able to allocate SurfaceIds 
(in particular, the LocalFrameId component of the SurfaceId) in the 
client.

1. SurfaceIdAllocator is moved to the //cc/surfaces:surface_id target so that it
can be used in the client.

2. MojoCompositorFrameSink::SubmitCompositorFrame is updated to take in
a LocalFrameId. The offscreen canvas and the mus client library is updated to
use this new signature.

3. GpuCompositorFrameSink is updated to assume new LocalFrameIds will be
allocated in the client instead.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Fady Samuel, 2016-11-22 18:08:36]

Description was changed from

==========
Display Compositor: Allocate LocalFrameId in client.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Display Compositor: Towards allocating SurfaceIds in the client

Currently, SurfaceIds are allocated in Mus or in the browser process.
This CL takes us a few steps towards being able to allocate SurfaceIds 
(in particular, the LocalFrameId component of the SurfaceId) in the 
client.

1. SurfaceIdAllocator is moved to the //cc/surfaces:surface_id target so that it
can be used in the client.

2. MojoCompositorFrameSink::SubmitCompositorFrame is updated to take in
a LocalFrameId. The offscreen canvas and the mus client library is updated to
use this new signature.

3. GpuCompositorFrameSink is updated to assume new LocalFrameIds will be
allocated in the client instead.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Fady Samuel, 2016-11-22 18:11:01]

Description was changed from

==========
Display Compositor: Towards allocating SurfaceIds in the client

Currently, SurfaceIds are allocated in Mus or in the browser process.
This CL takes us a few steps towards being able to allocate SurfaceIds 
(in particular, the LocalFrameId component of the SurfaceId) in the 
client.

1. SurfaceIdAllocator is moved to the //cc/surfaces:surface_id target so that it
can be used in the client.

2. MojoCompositorFrameSink::SubmitCompositorFrame is updated to take in
a LocalFrameId. The offscreen canvas and the mus client library is updated to
use this new signature.

3. GpuCompositorFrameSink is updated to assume new LocalFrameIds will be
allocated in the client instead.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Display Compositor: Towards allocating SurfaceIds in the client

Currently, SurfaceIds are allocated in Mus or in the browser process.
This CL takes us a few steps towards being able to allocate SurfaceIds 
(in particular, the LocalFrameId component of the SurfaceId) in the 
client.

1. SurfaceIdAllocator is moved to the //cc/surfaces:surface_id target so that it
can be used in the client.

2. MojoCompositorFrameSink::SubmitCompositorFrame is updated to take in
a LocalFrameId. The offscreen canvas and the mus client library is updated to
use this new signature.

3. GpuCompositorFrameSink is updated to assume new LocalFrameIds will be
allocated in the client instead.

BUG=664547
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Fady Samuel, 2016-11-22 18:11:52]

Description was changed from

==========
Display Compositor: Towards allocating SurfaceIds in the client

Currently, SurfaceIds are allocated in Mus or in the browser process.
This CL takes us a few steps towards being able to allocate SurfaceIds 
(in particular, the LocalFrameId component of the SurfaceId) in the 
client.

1. SurfaceIdAllocator is moved to the //cc/surfaces:surface_id target so that it
can be used in the client.

2. MojoCompositorFrameSink::SubmitCompositorFrame is updated to take in
a LocalFrameId. The offscreen canvas and the mus client library is updated to
use this new signature.

3. GpuCompositorFrameSink is updated to assume new LocalFrameIds will be
allocated in the client instead.

BUG=664547
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Display Compositor: Towards allocating SurfaceIds in the client

Currently, SurfaceIds are allocated in Mus or in the browser process.
This CL takes us a few steps towards being able to allocate SurfaceIds 
(in particular, the LocalFrameId component of the SurfaceId) in the 
client.

1. SurfaceIdAllocator is moved to the //cc/surfaces:surface_id target so that it
can be used in the client.

2. MojoCompositorFrameSink::SubmitCompositorFrame is updated to take in
a LocalFrameId. The offscreen canvas and the mus client library is updated to
use this new signature.

3. GpuCompositorFrameSink is updated to assume new LocalFrameIds will be
allocated in the client instead.

BUG=664547, 627283
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Fady Samuel, 2016-11-22 18:11:56]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[Fady Samuel, 2016-11-22 18:12:07]

Description was changed from

==========
Display Compositor: Towards allocating SurfaceIds in the client

Currently, SurfaceIds are allocated in Mus or in the browser process.
This CL takes us a few steps towards being able to allocate SurfaceIds 
(in particular, the LocalFrameId component of the SurfaceId) in the 
client.

1. SurfaceIdAllocator is moved to the //cc/surfaces:surface_id target so that it
can be used in the client.

2. MojoCompositorFrameSink::SubmitCompositorFrame is updated to take in
a LocalFrameId. The offscreen canvas and the mus client library is updated to
use this new signature.

3. GpuCompositorFrameSink is updated to assume new LocalFrameIds will be
allocated in the client instead.

BUG=664547, 627283
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Display Compositor: Towards allocating SurfaceIds in the client

Currently, SurfaceIds are allocated in Mus or in the browser process.
This CL takes us a few steps towards being able to allocate SurfaceIds 
(in particular, the LocalFrameId component of the SurfaceId) in the 
client.

1. SurfaceIdAllocator is moved to the //cc/surfaces:surface_id target 
so that it can be used in the client.

2. MojoCompositorFrameSink::SubmitCompositorFrame is updated to take in
a LocalFrameId. The offscreen canvas and the mus client library is 
updated to use this new signature.

3. GpuCompositorFrameSink is updated to assume new LocalFrameIds will 
be allocated in the client instead.

BUG=664547, 627283
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Fady Samuel, 2016-11-22 18:12:20]

fsamuel@chromium.org changed reviewers:
+ rjkroege@chromium.org, sadrul@chromium.org

[commit-bot: I haz the power, 2016-11-22 18:12:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rjkroege, 2016-11-22 18:34:02]

lgtm

https://codereview.chromium.org/2527443002/diff/20001/cc/ipc/mojo_compositor_...
File cc/ipc/mojo_compositor_frame_sink.mojom (right):

https://codereview.chromium.org/2527443002/diff/20001/cc/ipc/mojo_compositor_...
cc/ipc/mojo_compositor_frame_sink.mojom:29:
SubmitCompositorFrame(cc.mojom.LocalFrameId local_frame_id,
Could you document the parameters?

[rjkroege, 2016-11-22 18:34:03]

lgtm

https://codereview.chromium.org/2527443002/diff/20001/cc/ipc/mojo_compositor_...
File cc/ipc/mojo_compositor_frame_sink.mojom (right):

https://codereview.chromium.org/2527443002/diff/20001/cc/ipc/mojo_compositor_...
cc/ipc/mojo_compositor_frame_sink.mojom:29:
SubmitCompositorFrame(cc.mojom.LocalFrameId local_frame_id,
Could you document the parameters?

[Fady Samuel, 2016-11-22 18:39:57]

fsamuel@chromium.org changed reviewers:
+ junov@chromium.org, piman@chromium.org, sky@chromium.org, tsepez@chromium.org,
xlai@chromium.org

[Fady Samuel, 2016-11-22 18:39:58]

+piman@ for cc
+tsepez@ for mojom
+xlai@/junov@ for canvas things
+sky@ for services/ui and ui/

https://codereview.chromium.org/2527443002/diff/20001/cc/ipc/mojo_compositor_...
File cc/ipc/mojo_compositor_frame_sink.mojom (right):

https://codereview.chromium.org/2527443002/diff/20001/cc/ipc/mojo_compositor_...
cc/ipc/mojo_compositor_frame_sink.mojom:29:
SubmitCompositorFrame(cc.mojom.LocalFrameId local_frame_id,
On 2016/11/22 18:34:02, rjkroege wrote:
> Could you document the parameters?

Done.

[Fady Samuel, 2016-11-22 18:40:03]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 18:40:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-11-22 18:47:59]

This makes these IDs, in some sense, less trustworthy.  What happens if a client
fakes these?

[Fady Samuel, 2016-11-22 18:52:49]

On 2016/11/22 18:47:59, Tom Sepez wrote:
> This makes these IDs, in some sense, less trustworthy.  What happens if a
client
> fakes these?

It doesn't really matter if a client fakes these because they're scoped to that
particular client.

Resources in the browser or gpu process are accessible through a SurfaceId =
(FrameSinkId, LocalFrameId). A FrameSinkId is fixed for a client: the client
cannot submit a new one and cannot change it. The client can allocate new
LocalFrameIds (which have an unguessable token) and submit a CompositorFrame
with that ID.

Thus, this LocalFrameId is unguessable by other clients, and if the client fakes
the ID, then it cannot overwrite or modify resources it doesn't own because the
LocalFrameId is scoped to a fixed FrameSinkId.

[commit-bot: I haz the power, 2016-11-22 19:03:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 19:03:35]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[sadrul, 2016-11-22 19:22:25]

https://codereview.chromium.org/2527443002/diff/40001/ui/aura/mus/window_comp...
File ui/aura/mus/window_compositor_frame_sink.cc (right):

https://codereview.chromium.org/2527443002/diff/40001/ui/aura/mus/window_comp...
ui/aura/mus/window_compositor_frame_sink.cc:69: if
(!frame.render_pass_list.empty())
Is it valid for a frame to have no render-pass? (applies to all the rest of the
places this is checked)

[Fady Samuel, 2016-11-22 19:24:38]

https://codereview.chromium.org/2527443002/diff/40001/ui/aura/mus/window_comp...
File ui/aura/mus/window_compositor_frame_sink.cc (right):

https://codereview.chromium.org/2527443002/diff/40001/ui/aura/mus/window_comp...
ui/aura/mus/window_compositor_frame_sink.cc:69: if
(!frame.render_pass_list.empty())
On 2016/11/22 19:22:25, sadrul wrote:
> Is it valid for a frame to have no render-pass? (applies to all the rest of
the
> places this is checked)

The pattern of submitting an empty CompositorFrame is used in some places to
evict resources used by the previous frame.

[sadrul, 2016-11-22 19:25:48]

https://codereview.chromium.org/2527443002/diff/40001/ui/aura/mus/window_comp...
File ui/aura/mus/window_compositor_frame_sink.cc (right):

https://codereview.chromium.org/2527443002/diff/40001/ui/aura/mus/window_comp...
ui/aura/mus/window_compositor_frame_sink.cc:69: if
(!frame.render_pass_list.empty())
On 2016/11/22 19:24:38, Fady Samuel wrote:
> On 2016/11/22 19:22:25, sadrul wrote:
> > Is it valid for a frame to have no render-pass? (applies to all the rest of
> the
> > places this is checked)
> 
> The pattern of submitting an empty CompositorFrame is used in some places to
> evict resources used by the previous frame.

I see. Should that reset the frame/frame-sink size and id?

[Fady Samuel, 2016-11-22 19:28:11]

On 2016/11/22 19:25:48, sadrul wrote:
>
https://codereview.chromium.org/2527443002/diff/40001/ui/aura/mus/window_comp...
> File ui/aura/mus/window_compositor_frame_sink.cc (right):
> 
>
https://codereview.chromium.org/2527443002/diff/40001/ui/aura/mus/window_comp...
> ui/aura/mus/window_compositor_frame_sink.cc:69: if
> (!frame.render_pass_list.empty())
> On 2016/11/22 19:24:38, Fady Samuel wrote:
> > On 2016/11/22 19:22:25, sadrul wrote:
> > > Is it valid for a frame to have no render-pass? (applies to all the rest
of
> > the
> > > places this is checked)
> > 
> > The pattern of submitting an empty CompositorFrame is used in some places to
> > evict resources used by the previous frame.
> 
> I see. Should that reset the frame/frame-sink size and id?

I don't believe so. We don't want to destroy the surface. We simply want to
free/return the resources associated with the previous frame.

[Tom Sepez, 2016-11-22 19:33:32]

lgtm

[Fady Samuel, 2016-11-22 19:36:53]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 19:37:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2016-11-22 19:45:19]

On 2016/11/22 19:28:11, Fady Samuel wrote:
> On 2016/11/22 19:25:48, sadrul wrote:
> >
>
https://codereview.chromium.org/2527443002/diff/40001/ui/aura/mus/window_comp...
> > File ui/aura/mus/window_compositor_frame_sink.cc (right):
> > 
> >
>
https://codereview.chromium.org/2527443002/diff/40001/ui/aura/mus/window_comp...
> > ui/aura/mus/window_compositor_frame_sink.cc:69: if
> > (!frame.render_pass_list.empty())
> > On 2016/11/22 19:24:38, Fady Samuel wrote:
> > > On 2016/11/22 19:22:25, sadrul wrote:
> > > > Is it valid for a frame to have no render-pass? (applies to all the rest
> of
> > > the
> > > > places this is checked)
> > > 
> > > The pattern of submitting an empty CompositorFrame is used in some places
to
> > > evict resources used by the previous frame.
> > 
> > I see. Should that reset the frame/frame-sink size and id?
> 
> I don't believe so. We don't want to destroy the surface. We simply want to
> free/return the resources associated with the previous frame.

Should you keep the old local_frame_id_/last_frame_size_ then when this happens,
instead of setting |last_frame_size_| to an empty rect, getting a new frame-id,
then get a newer id again when a non-empty frame is submitted?

[Fady Samuel, 2016-11-22 19:49:50]

Ohh I see, PTAL sadrul@. Agreed.

[Fady Samuel, 2016-11-22 19:51:50]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 19:52:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2016-11-22 19:53:30]

Some nits. A couple of questions. lgtm with those addressed.

https://codereview.chromium.org/2527443002/diff/80001/content/browser/rendere...
File content/browser/renderer_host/offscreen_canvas_compositor_frame_sink.cc
(right):

https://codereview.chromium.org/2527443002/diff/80001/content/browser/rendere...
content/browser/renderer_host/offscreen_canvas_compositor_frame_sink.cc:48:
const cc::LocalFrameId& local_frame_Id,
*id

https://codereview.chromium.org/2527443002/diff/80001/content/browser/rendere...
content/browser/renderer_host/offscreen_canvas_compositor_frame_sink.cc:52:
surface_id_.local_frame_id(), std::move(frame),
Do you want to use |local_frame_id| here instead?

https://codereview.chromium.org/2527443002/diff/80001/services/ui/public/cpp/...
File services/ui/public/cpp/window_compositor_frame_sink.cc (right):

https://codereview.chromium.org/2527443002/diff/80001/services/ui/public/cpp/...
services/ui/public/cpp/window_compositor_frame_sink.cc:69: gfx::Size frame_size
= last_submitted_frame_sink_;
*size_

https://codereview.chromium.org/2527443002/diff/80001/services/ui/ws/frame_ge...
File services/ui/ws/frame_generator.cc (right):

https://codereview.chromium.org/2527443002/diff/80001/services/ui/ws/frame_ge...
services/ui/ws/frame_generator.cc:134: gfx::Size frame_size;
= last_submitted_frame_size_;

https://codereview.chromium.org/2527443002/diff/80001/services/ui/ws/gpu_comp...
File services/ui/ws/gpu_compositor_frame_sink.cc (right):

https://codereview.chromium.org/2527443002/diff/80001/services/ui/ws/gpu_comp...
services/ui/ws/gpu_compositor_frame_sink.cc:82: display_->Resize(frame_size);
Do this Resize only if |frame_size| is non-empty?

[commit-bot: I haz the power, 2016-11-22 20:07:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 20:07:13]

Dry run: Try jobs failed on following builders:
  linux_trusty_blink_rel on master.tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_trusty_blink_rel/b...)

[Fady Samuel, 2016-11-22 20:17:11]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[Fady Samuel, 2016-11-22 20:17:27]

PTAL piman@, junov@, sky@! Thanks!

https://codereview.chromium.org/2527443002/diff/80001/content/browser/rendere...
File content/browser/renderer_host/offscreen_canvas_compositor_frame_sink.cc
(right):

https://codereview.chromium.org/2527443002/diff/80001/content/browser/rendere...
content/browser/renderer_host/offscreen_canvas_compositor_frame_sink.cc:48:
const cc::LocalFrameId& local_frame_Id,
On 2016/11/22 19:53:29, sadrul wrote:
> *id

Done.

https://codereview.chromium.org/2527443002/diff/80001/content/browser/rendere...
content/browser/renderer_host/offscreen_canvas_compositor_frame_sink.cc:52:
surface_id_.local_frame_id(), std::move(frame),
On 2016/11/22 19:53:29, sadrul wrote:
> Do you want to use |local_frame_id| here instead?

Not yet. I don't want to change offscreen canvas yet. The offscreen canvas team
is currently changing that code.

https://codereview.chromium.org/2527443002/diff/80001/services/ui/public/cpp/...
File services/ui/public/cpp/window_compositor_frame_sink.cc (right):

https://codereview.chromium.org/2527443002/diff/80001/services/ui/public/cpp/...
services/ui/public/cpp/window_compositor_frame_sink.cc:69: gfx::Size frame_size
= last_submitted_frame_sink_;
On 2016/11/22 19:53:29, sadrul wrote:
> *size_

Done.

https://codereview.chromium.org/2527443002/diff/80001/services/ui/ws/frame_ge...
File services/ui/ws/frame_generator.cc (right):

https://codereview.chromium.org/2527443002/diff/80001/services/ui/ws/frame_ge...
services/ui/ws/frame_generator.cc:134: gfx::Size frame_size;
On 2016/11/22 19:53:29, sadrul wrote:
> = last_submitted_frame_size_;

Done.

https://codereview.chromium.org/2527443002/diff/80001/services/ui/ws/gpu_comp...
File services/ui/ws/gpu_compositor_frame_sink.cc (right):

https://codereview.chromium.org/2527443002/diff/80001/services/ui/ws/gpu_comp...
services/ui/ws/gpu_compositor_frame_sink.cc:82: display_->Resize(frame_size);
On 2016/11/22 19:53:29, sadrul wrote:
> Do this Resize only if |frame_size| is non-empty?

Done.

[commit-bot: I haz the power, 2016-11-22 20:17:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Fady Samuel, 2016-11-22 20:24:55]

fsamuel@chromium.org changed reviewers:
+ jbroman@chromium.org

[Fady Samuel, 2016-11-22 20:24:56]

junov@ is OOO, +jbroman@

[Fady Samuel, 2016-11-22 20:43:05]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 20:43:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Fady Samuel, 2016-11-22 20:44:42]

fsamuel@chromium.org changed reviewers:
+ boliu@chromium.org

[Fady Samuel, 2016-11-22 20:44:43]

+boliu@ for android_webview.

[boliu, 2016-11-22 20:55:04]

lgtm

[sky, 2016-11-22 21:07:05]

LGTM

[commit-bot: I haz the power, 2016-11-22 22:14:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 22:15:00]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Fady Samuel, 2016-11-22 22:40:13]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2016-11-22 22:40:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
rjkroege@chromium.org, tsepez@chromium.org, sadrul@chromium.org,
sky@chromium.org, boliu@chromium.org
Link to the patchset: https://codereview.chromium.org/2527443002/#ps140001
(title: "Rebased + Restored BUILD files")

[commit-bot: I haz the power, 2016-11-22 22:40:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Fady Samuel, 2016-11-22 23:15:44]

Description was changed from

==========
Display Compositor: Towards allocating SurfaceIds in the client

Currently, SurfaceIds are allocated in Mus or in the browser process.
This CL takes us a few steps towards being able to allocate SurfaceIds 
(in particular, the LocalFrameId component of the SurfaceId) in the 
client.

1. SurfaceIdAllocator is moved to the //cc/surfaces:surface_id target 
so that it can be used in the client.

2. MojoCompositorFrameSink::SubmitCompositorFrame is updated to take in
a LocalFrameId. The offscreen canvas and the mus client library is 
updated to use this new signature.

3. GpuCompositorFrameSink is updated to assume new LocalFrameIds will 
be allocated in the client instead.

BUG=664547, 627283
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Display Compositor: Towards allocating SurfaceIds in the client

Currently, SurfaceIds are allocated in Mus or in the browser process.
This CL takes us a few steps towards being able to allocate SurfaceIds 
(in particular, the LocalFrameId component of the SurfaceId) in the 
client.

1. MojoCompositorFrameSink::SubmitCompositorFrame is updated to take in
a LocalFrameId. Offscreen canvas and the mus client library is 
updated to use this new signature.

2. GpuCompositorFrameSink is updated to assume new LocalFrameIds will 
be allocated in the client instead.

BUG=664547, 627283
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[commit-bot: I haz the power, 2016-11-22 23:17:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 23:17:11]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jbroman, 2016-11-23 00:25:08]

platform lgtm

[Fady Samuel, 2016-11-23 00:28:44]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2016-11-23 00:29:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 00:51:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 00:51:45]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Fady Samuel, 2016-11-23 00:55:28]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2016-11-23 00:56:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 01:15:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 01:15:12]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Fady Samuel, 2016-11-23 01:16:59]

Description was changed from

==========
Display Compositor: Towards allocating SurfaceIds in the client

Currently, SurfaceIds are allocated in Mus or in the browser process.
This CL takes us a few steps towards being able to allocate SurfaceIds 
(in particular, the LocalFrameId component of the SurfaceId) in the 
client.

1. MojoCompositorFrameSink::SubmitCompositorFrame is updated to take in
a LocalFrameId. Offscreen canvas and the mus client library is 
updated to use this new signature.

2. GpuCompositorFrameSink is updated to assume new LocalFrameIds will 
be allocated in the client instead.

BUG=664547, 627283
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Display Compositor: Towards allocating SurfaceIds in the client

Currently, SurfaceIds are allocated in Mus or in the browser process.
This CL takes us a few steps towards being able to allocate SurfaceIds 
(in particular, the LocalFrameId component of the SurfaceId) in the 
client.

1. MojoCompositorFrameSink::SubmitCompositorFrame is updated to take in
a LocalFrameId. Offscreen canvas and the mus client library is 
updated to use this new signature.

2. GpuCompositorFrameSink is updated to assume new LocalFrameIds will 
be allocated in the client instead.

BUG=664547, 627283
TBR=piman@chromium.org for new DEPS on surface_id_allocator.h
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Fady Samuel, 2016-11-23 01:17:24]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2016-11-23 01:17:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[piman, 2016-11-23 01:20:50]

lgtm

[commit-bot: I haz the power, 2016-11-23 02:37:43]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1479863844782270,
"parent_rev": "28a3a4662965309deb2983f64a89551d6c5461c4", "commit_rev":
"c70421f6cb4cc7954944de8bda539ad0f5dc81ea"}

[commit-bot: I haz the power, 2016-11-23 02:38:13]

Description was changed from

==========
Display Compositor: Towards allocating SurfaceIds in the client

Currently, SurfaceIds are allocated in Mus or in the browser process.
This CL takes us a few steps towards being able to allocate SurfaceIds 
(in particular, the LocalFrameId component of the SurfaceId) in the 
client.

1. MojoCompositorFrameSink::SubmitCompositorFrame is updated to take in
a LocalFrameId. Offscreen canvas and the mus client library is 
updated to use this new signature.

2. GpuCompositorFrameSink is updated to assume new LocalFrameIds will 
be allocated in the client instead.

BUG=664547, 627283
TBR=piman@chromium.org for new DEPS on surface_id_allocator.h
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Display Compositor: Towards allocating SurfaceIds in the client

Currently, SurfaceIds are allocated in Mus or in the browser process.
This CL takes us a few steps towards being able to allocate SurfaceIds 
(in particular, the LocalFrameId component of the SurfaceId) in the 
client.

1. MojoCompositorFrameSink::SubmitCompositorFrame is updated to take in
a LocalFrameId. Offscreen canvas and the mus client library is 
updated to use this new signature.

2. GpuCompositorFrameSink is updated to assume new LocalFrameIds will 
be allocated in the client instead.

BUG=664547, 627283
TBR=piman@chromium.org for new DEPS on surface_id_allocator.h
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[commit-bot: I haz the power, 2016-11-23 02:38:15]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-11-23 02:41:10]

Description was changed from

==========
Display Compositor: Towards allocating SurfaceIds in the client

Currently, SurfaceIds are allocated in Mus or in the browser process.
This CL takes us a few steps towards being able to allocate SurfaceIds 
(in particular, the LocalFrameId component of the SurfaceId) in the 
client.

1. MojoCompositorFrameSink::SubmitCompositorFrame is updated to take in
a LocalFrameId. Offscreen canvas and the mus client library is 
updated to use this new signature.

2. GpuCompositorFrameSink is updated to assume new LocalFrameIds will 
be allocated in the client instead.

BUG=664547, 627283
TBR=piman@chromium.org for new DEPS on surface_id_allocator.h
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Display Compositor: Towards allocating SurfaceIds in the client

Currently, SurfaceIds are allocated in Mus or in the browser process.
This CL takes us a few steps towards being able to allocate SurfaceIds
(in particular, the LocalFrameId component of the SurfaceId) in the
client.

1. MojoCompositorFrameSink::SubmitCompositorFrame is updated to take in
a LocalFrameId. Offscreen canvas and the mus client library is
updated to use this new signature.

2. GpuCompositorFrameSink is updated to assume new LocalFrameIds will
be allocated in the client instead.

BUG=664547, 627283
TBR=piman@chromium.org for new DEPS on surface_id_allocator.h
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Committed: https://crrev.com/e3d2888a771050099facf2b18c3d72b4922c9581
Cr-Commit-Position: refs/heads/master@{#434091}
==========

[commit-bot: I haz the power, 2016-11-23 02:41:12]

Patchset 8 (id:??) landed as
https://crrev.com/e3d2888a771050099facf2b18c3d72b4922c9581
Cr-Commit-Position: refs/heads/master@{#434091}