Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Side by Side Diff: cc/ipc/mojo_compositor_frame_sink.mojom

Issue 2527443002: Display Compositor: Allocate LocalFrameId in client. (Closed)
Patch Set: Rebased + Restored BUILD files Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/browser/renderer_host/offscreen_canvas_compositor_frame_sink.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 module cc.mojom; 5 module cc.mojom;
6 6
7 import "cc/ipc/begin_frame_args.mojom"; 7 import "cc/ipc/begin_frame_args.mojom";
8 import "cc/ipc/compositor_frame.mojom"; 8 import "cc/ipc/compositor_frame.mojom";
9 import "cc/ipc/frame_sink_id.mojom"; 9 import "cc/ipc/frame_sink_id.mojom";
10 import "cc/ipc/local_frame_id.mojom";
10 import "cc/ipc/returned_resource.mojom"; 11 import "cc/ipc/returned_resource.mojom";
11 12
12 // A MojoCompositorFrameSink is an interface for receiving CompositorFrame 13 // A MojoCompositorFrameSink is an interface for receiving CompositorFrame
13 // structs. A CompositorFrame contains the complete output meant for display. 14 // structs. A CompositorFrame contains the complete output meant for display.
14 // Each time a client has a graphical update, and receives an OnBeginFrame, it 15 // Each time a client has a graphical update, and receives an OnBeginFrame, it
15 // is responsible for creating a CompositorFrame to update its portion of the 16 // is responsible for creating a CompositorFrame to update its portion of the
16 // screen. 17 // screen.
17 interface MojoCompositorFrameSink { 18 interface MojoCompositorFrameSink {
18 // Lets the display compositor know that the client wishes to receive the next 19 // Lets the display compositor know that the client wishes to receive the next
19 // BeginFrame event. 20 // BeginFrame event.
20 SetNeedsBeginFrame(bool needs_begin_frame); 21 SetNeedsBeginFrame(bool needs_begin_frame);
21 22
22 // Submits a CompositorFrame to the display compositor that will be presented 23 // Submits a CompositorFrame to the display compositor that will be presented
23 // to screen the next time frames from all CompositorFrameSinks are aggregated 24 // to screen the next time frames from all CompositorFrameSinks are aggregated
24 // to produce a display CompositorFrame. 25 // to produce a display CompositorFrame. If a client wishes to allocate a new
26 // surface (e.g. during resize), then it can simply allocate a new
27 // |local_frame_id|.
25 // For successful swaps, the implementation must call 28 // For successful swaps, the implementation must call
26 // DidReceiveCompositorFrameAck() asynchronously when the frame has been 29 // DidReceiveCompositorFrameAck() asynchronously when the frame has been
27 // processed in order to unthrottle the next frame. 30 // processed in order to unthrottle the next frame.
28 SubmitCompositorFrame(cc.mojom.CompositorFrame frame); 31 SubmitCompositorFrame(cc.mojom.LocalFrameId local_frame_id,
32 cc.mojom.CompositorFrame frame);
29 33
30 // TODO(fsamuel): ReadbackBitmap API would be useful here. 34 // TODO(fsamuel): ReadbackBitmap API would be useful here.
31 }; 35 };
32 36
33 interface MojoCompositorFrameSinkClient { 37 interface MojoCompositorFrameSinkClient {
34 // Notification that the previous CompositorFrame given to 38 // Notification that the previous CompositorFrame given to
35 // SubmitCompositorFrame() has been processed and that another frame 39 // SubmitCompositorFrame() has been processed and that another frame
36 // can be submitted. This provides backpressure from the display compositor 40 // can be submitted. This provides backpressure from the display compositor
37 // so that frames are submitted only at the rate it can handle them. 41 // so that frames are submitted only at the rate it can handle them.
38 // TODO(fsamuel): This method ought not be necessary with unified BeginFrame. 42 // TODO(fsamuel): This method ought not be necessary with unified BeginFrame.
39 // However, there's a fair amount of cleanup and refactoring necessary to get 43 // However, there's a fair amount of cleanup and refactoring necessary to get
40 // rid of it. 44 // rid of it.
41 DidReceiveCompositorFrameAck(); 45 DidReceiveCompositorFrameAck();
42 46
43 // Notification for the client to generate a CompositorFrame. 47 // Notification for the client to generate a CompositorFrame.
44 OnBeginFrame(BeginFrameArgs args); 48 OnBeginFrame(BeginFrameArgs args);
45 49
46 // Returns resources sent to SubmitCompositorFrame to be reused or freed. 50 // Returns resources sent to SubmitCompositorFrame to be reused or freed.
47 ReclaimResources(ReturnedResourceArray resources); 51 ReclaimResources(ReturnedResourceArray resources);
48 }; 52 };
49 53
50 // MojoCompositorFrameSinkPrivate is used by the display compositor host to set 54 // MojoCompositorFrameSinkPrivate is used by the display compositor host to set
51 // up BeginFrameSource hierarchies. This API lives in SurfaceManager but is 55 // up BeginFrameSource hierarchies. This API lives in SurfaceManager but is
52 // called from here in order to ensure that hierarchy registration does not race 56 // called from here in order to ensure that hierarchy registration does not race
53 // CompositorFrameSink creation. 57 // CompositorFrameSink creation.
54 interface MojoCompositorFrameSinkPrivate { 58 interface MojoCompositorFrameSinkPrivate {
55 AddChildFrameSink(FrameSinkId child_frame_sink_id); 59 AddChildFrameSink(FrameSinkId child_frame_sink_id);
56 RemoveChildFrameSink(FrameSinkId child_frame_sink_id); 60 RemoveChildFrameSink(FrameSinkId child_frame_sink_id);
57 }; 61 };
OLDNEW
« no previous file with comments | « no previous file | content/browser/renderer_host/offscreen_canvas_compositor_frame_sink.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698