Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: net/DEPS

Issue 252733002: Consolidate most of net/'s icu_string_conversions.h dependencies. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Fix mac Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/base/escape_unittest.cc » ('j') | net/base/net_string_util_icu.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/DEPS
===================================================================
--- net/DEPS (revision 266199)
+++ net/DEPS (working copy)
@@ -23,7 +23,7 @@
# Within net, only used by file: requests.
"filename_util\.cc": [
- "+base/i18n",
+ "+base/i18n/file_util_icu.h",
],
# Functions largely not used by the rest of net.
@@ -37,26 +37,17 @@
"+base/i18n",
],
- # Only use icu for string conversions.
- "escape_unittest\.cc": [
+ # Consolidated string functions that depend on icu.
+ "net_string_util_icu\.cc": [
+ "+base/i18n/i18n_constants.h",
"+base/i18n/icu_string_conversions.h",
+ "+third_party/icu/source/common/unicode/ucnv.h"
],
- "http_auth_handler_basic\.cc": [
- "+base/i18n/icu_string_conversions.h",
- ],
- "http_auth_handler_digest\.cc": [
- "+base/i18n/icu_string_conversions.h",
- ],
+
+ # Only use icu for string conversions.
"proxy_script_fetcher_impl\.cc": [
"+base/i18n/icu_string_conversions.h",
],
mmenke 2014/04/28 19:01:37 Not sure if we need to do this one. It also uses
- "x509_cert_types_mac\.cc": [
- "+base/i18n/icu_string_conversions.h",
- ],
- "http_content_disposition\.cc": [
- "+base/i18n/icu_string_conversions.h",
- "+third_party/icu",
- ],
"websocket_channel\.h": [
"+base/i18n",
],
« no previous file with comments | « no previous file | net/base/escape_unittest.cc » ('j') | net/base/net_string_util_icu.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698