Chromium Code Reviews Chromium Code Reviews
Issue 252733002:
Consolidate most of net/'s icu_string_conversions.h dependencies. (Closed)
Base URL: svn://svn.chromium.org/chrome/trunk/src/| OLD | NEW |
|---|---|
| 1 include_rules = [ | 1 include_rules = [ |
| 2 "+crypto", | 2 "+crypto", |
| 3 "+gin/public", | 3 "+gin/public", |
| 4 "+jni", | 4 "+jni", |
| 5 "+third_party/apple_apsl", | 5 "+third_party/apple_apsl", |
| 6 "+third_party/libevent", | 6 "+third_party/libevent", |
| 7 "+third_party/nss", | 7 "+third_party/nss", |
| 8 "+third_party/zlib", | 8 "+third_party/zlib", |
| 9 "+sdch/open-vcdiff", | 9 "+sdch/open-vcdiff", |
| 10 "+v8", | 10 "+v8", |
| 11 | 11 |
| 12 # Most of net should not depend on icu, to keep size down when built as a | 12 # Most of net should not depend on icu, to keep size down when built as a |
| 13 # library. | 13 # library. |
| 14 "-base/i18n", | 14 "-base/i18n", |
| 15 "-third_party/icu", | 15 "-third_party/icu", |
| 16 ] | 16 ] |
| 17 | 17 |
| 18 specific_include_rules = { | 18 specific_include_rules = { |
| 19 # Within net, only used by file: requests. | 19 # Within net, only used by file: requests. |
| 20 "directory_lister(\.cc|_unittest\.cc)": [ | 20 "directory_lister(\.cc|_unittest\.cc)": [ |
| 21 "+base/i18n", | 21 "+base/i18n", |
| 22 ], | 22 ], |
| 23 | 23 |
| 24 # Within net, only used by file: requests. | 24 # Within net, only used by file: requests. |
| 25 "filename_util\.cc": [ | 25 "filename_util\.cc": [ |
| 26 "+base/i18n", | 26 "+base/i18n/file_util_icu.h", |
| 27 ], | 27 ], |
| 28 | 28 |
| 29 # Functions largely not used by the rest of net. | 29 # Functions largely not used by the rest of net. |
| 30 "net_util_icu\.cc": [ | 30 "net_util_icu\.cc": [ |
| 31 "+base/i18n", | 31 "+base/i18n", |
| 32 "+third_party/icu", | 32 "+third_party/icu", |
| 33 ], | 33 ], |
| 34 | 34 |
| 35 # Uses icu for debug logging only. | 35 # Uses icu for debug logging only. |
| 36 "network_time_notifier\.cc": [ | 36 "network_time_notifier\.cc": [ |
| 37 "+base/i18n", | 37 "+base/i18n", |
| 38 ], | 38 ], |
| 39 | 39 |
| 40 # Consolidated string functions that depend on icu. | |
| 41 "net_string_util_icu\.cc": [ | |
| 42 "+base/i18n/i18n_constants.h", | |
| 43 "+base/i18n/icu_string_conversions.h", | |
| 44 "+third_party/icu/source/common/unicode/ucnv.h" | |
| 45 ], | |
| 46 | |
| 40 # Only use icu for string conversions. | 47 # Only use icu for string conversions. |
| 41 "escape_unittest\.cc": [ | |
| 42 "+base/i18n/icu_string_conversions.h", | |
| 43 ], | |
| 44 "http_auth_handler_basic\.cc": [ | |
| 45 "+base/i18n/icu_string_conversions.h", | |
| 46 ], | |
| 47 "http_auth_handler_digest\.cc": [ | |
| 48 "+base/i18n/icu_string_conversions.h", | |
| 49 ], | |
| 50 "proxy_script_fetcher_impl\.cc": [ | 48 "proxy_script_fetcher_impl\.cc": [ |
| 51 "+base/i18n/icu_string_conversions.h", | 49 "+base/i18n/icu_string_conversions.h", |
| 52 ], | 50 ], |
|
mmenke
2014/04/28 19:01:37
Not sure if we need to do this one. It also uses
| |
| 53 "x509_cert_types_mac\.cc": [ | |
| 54 "+base/i18n/icu_string_conversions.h", | |
| 55 ], | |
| 56 "http_content_disposition\.cc": [ | |
| 57 "+base/i18n/icu_string_conversions.h", | |
| 58 "+third_party/icu", | |
| 59 ], | |
| 60 "websocket_channel\.h": [ | 51 "websocket_channel\.h": [ |
| 61 "+base/i18n", | 52 "+base/i18n", |
| 62 ], | 53 ], |
| 63 | 54 |
| 64 "ftp_util\.cc": [ | 55 "ftp_util\.cc": [ |
| 65 "+base/i18n", | 56 "+base/i18n", |
| 66 "+third_party/icu", | 57 "+third_party/icu", |
| 67 ], | 58 ], |
| 68 "ftp_directory_listing_parser\.cc": [ | 59 "ftp_directory_listing_parser\.cc": [ |
| 69 "+base/i18n", | 60 "+base/i18n", |
| 70 ], | 61 ], |
| 71 } | 62 } |
| 72 | 63 |
| 73 skip_child_includes = [ | 64 skip_child_includes = [ |
| 74 "third_party", | 65 "third_party", |
| 75 "tools/flip_server", | 66 "tools/flip_server", |
| 76 ] | 67 ] |
| OLD | NEW |
