CSS Motion Path: offset-anchor should default to auto

CSS Motion Path: offset-anchor should default to auto

Spec:
https://drafts.fxtf.org/motion-1/#offset-anchor-property

BUG=668563
Committed: https://crrev.com/5abab5bf52101b3dda60511e36306bd1aa70d2f2
Cr-Commit-Position: refs/heads/master@{#438438}

[Eric Willigers, 2016-11-25 00:03:14]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-25 00:03:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-25 01:32:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-25 01:32:40]

Dry run: This issue passed the CQ dry run.

[Eric Willigers, 2016-11-25 01:44:37]

ericwilligers@chromium.org changed reviewers:
+ alancutter@chromium.org

[alancutter (OOO until 2018), 2016-11-28 06:28:27]

lgtm after adding spec link.

[Eric Willigers, 2016-12-11 10:43:32]

Description was changed from

==========
CSS Motion Path: offset-anchor should default to auto

BUG=668563
==========

to

==========
CSS Motion Path: offset-anchor should default to auto

Spec:
https://drafts.fxtf.org/motion-1/#offset-anchor-property

BUG=668563
==========

[Eric Willigers, 2016-12-11 12:16:15]

The CQ bit was checked by ericwilligers@chromium.org

[commit-bot: I haz the power, 2016-12-11 12:16:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-11 12:28:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-11 12:28:16]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Eric Willigers, 2016-12-11 17:47:55]

ericwilligers@chromium.org changed reviewers:
+ sashab@chromium.org

[Eric Willigers, 2016-12-11 17:47:56]

+Sasha for owner

[Eric Willigers, 2016-12-11 17:48:01]

+Sasha for owner

[sashab, 2016-12-12 01:11:26]

https://codereview.chromium.org/2527303002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/style/ComputedStyle.cpp (right):

https://codereview.chromium.org/2527303002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/style/ComputedStyle.cpp:1394: if (position.x() !=
Length(Auto) || anchor.x() != Length(Auto)) {
You removed a runtime enabled feature flag? Please add that to the CL
description.

Also is this if statement needed? I feel like the originShift code should apply
and work and handle the Auto case. Maybe I'm misunderstanding what this is for;
if so, a comment is needed.

https://codereview.chromium.org/2527303002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/style/ComputedStyle.cpp:1406: if (position.x() !=
Length(Auto) || anchor.x() != Length(Auto))
Why only x() and not y()?

[Eric Willigers, 2016-12-12 01:57:14]

rebased, added comments

https://codereview.chromium.org/2527303002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/style/ComputedStyle.cpp (right):

https://codereview.chromium.org/2527303002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/style/ComputedStyle.cpp:1394: if (position.x() !=
Length(Auto) || anchor.x() != Length(Auto)) {
On 2016/12/12 01:11:26, sashab wrote:
> You removed a runtime enabled feature flag? Please add that to the CL
> description.
> 
> Also is this if statement needed? I feel like the originShift code should
apply
> and work and handle the Auto case. Maybe I'm misunderstanding what this is
for;
> if so, a comment is needed.

comments added

https://codereview.chromium.org/2527303002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/style/ComputedStyle.cpp:1406: if (position.x() !=
Length(Auto) || anchor.x() != Length(Auto))
On 2016/12/12 01:11:26, sashab wrote:
> Why only x() and not y()?

position and anchor are 
<position> | auto
i.e. either a pair of positions, or auto.

Checking y would be redundant.

[sashab, 2016-12-12 02:00:57]

lgtm

[Eric Willigers, 2016-12-12 02:02:18]

The CQ bit was checked by ericwilligers@chromium.org

[Eric Willigers, 2016-12-12 02:02:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/2527303002/#ps20001
(title: "comments")

[commit-bot: I haz the power, 2016-12-12 02:02:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 03:33:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 03:33:39]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Eric Willigers, 2016-12-14 02:53:52]

The CQ bit was checked by ericwilligers@chromium.org

[commit-bot: I haz the power, 2016-12-14 02:54:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 05:06:50]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481684032483600,
"parent_rev": "edb364705ce7daa4ced4fdb8dfa91b2135256fa9", "commit_rev":
"24d0346fb0bf05fbbefe54f3c3814badf1f7cd16"}

[commit-bot: I haz the power, 2016-12-14 05:08:07]

Description was changed from

==========
CSS Motion Path: offset-anchor should default to auto

Spec:
https://drafts.fxtf.org/motion-1/#offset-anchor-property

BUG=668563
==========

to

==========
CSS Motion Path: offset-anchor should default to auto

Spec:
https://drafts.fxtf.org/motion-1/#offset-anchor-property

BUG=668563

Review-Url: https://codereview.chromium.org/2527303002
==========

[commit-bot: I haz the power, 2016-12-14 05:08:08]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-14 05:11:52]

Description was changed from

==========
CSS Motion Path: offset-anchor should default to auto

Spec:
https://drafts.fxtf.org/motion-1/#offset-anchor-property

BUG=668563

Review-Url: https://codereview.chromium.org/2527303002
==========

to

==========
CSS Motion Path: offset-anchor should default to auto

Spec:
https://drafts.fxtf.org/motion-1/#offset-anchor-property

BUG=668563

Committed: https://crrev.com/5abab5bf52101b3dda60511e36306bd1aa70d2f2
Cr-Commit-Position: refs/heads/master@{#438438}
==========

[commit-bot: I haz the power, 2016-12-14 05:11:53]

Patchset 2 (id:??) landed as
https://crrev.com/5abab5bf52101b3dda60511e36306bd1aa70d2f2
Cr-Commit-Position: refs/heads/master@{#438438}