Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2527293002: [Offline pages] Adding AddRequestTask to Request Queue (Closed)

Created:
4 years ago by fgorski
Modified:
4 years ago
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline pages] Adding AddRequestTask to Request Queue This patch adds AddRequestTask with its tests to ensure request queue operations are properly sequenced. BUG=651238 Committed: https://crrev.com/22733070dd04a7d43e7dc3140a73b7592530dae8 Cr-Commit-Position: refs/heads/master@{#434938}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Udpating test to address feedback #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+268 lines, -1 line) Patch
M components/offline_pages/background/BUILD.gn View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
A components/offline_pages/background/add_request_task.h View 1 chunk +46 lines, -0 lines 0 comments Download
A components/offline_pages/background/add_request_task.cc View 1 chunk +36 lines, -0 lines 0 comments Download
A components/offline_pages/background/add_request_task_unittest.cc View 1 1 chunk +179 lines, -0 lines 0 comments Download
M components/offline_pages/background/request_queue.cc View 1 2 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 25 (15 generated)
fgorski
PTAL. The reason for a failure in testRemoveRequestsFromQueue is the fact that GetRequests is not ...
4 years ago (2016-11-28 17:02:34 UTC) #6
dougarnett
https://codereview.chromium.org/2527293002/diff/1/components/offline_pages/background/add_request_task_unittest.cc File components/offline_pages/background/add_request_task_unittest.cc (right): https://codereview.chromium.org/2527293002/diff/1/components/offline_pages/background/add_request_task_unittest.cc#newcode109 components/offline_pages/background/add_request_task_unittest.cc:109: RequestQueueInMemoryStore store; Perhaps comment that this store returns objects ...
4 years ago (2016-11-28 19:11:34 UTC) #7
fgorski
Addressed https://codereview.chromium.org/2527293002/diff/1/components/offline_pages/background/add_request_task_unittest.cc File components/offline_pages/background/add_request_task_unittest.cc (right): https://codereview.chromium.org/2527293002/diff/1/components/offline_pages/background/add_request_task_unittest.cc#newcode109 components/offline_pages/background/add_request_task_unittest.cc:109: RequestQueueInMemoryStore store; On 2016/11/28 19:11:34, dougarnett wrote: > ...
4 years ago (2016-11-28 21:08:03 UTC) #9
Pete Williamson
lgtm
4 years ago (2016-11-28 21:18:47 UTC) #11
dougarnett
lgtm
4 years ago (2016-11-28 21:27:14 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2527293002/20001
4 years ago (2016-11-28 23:17:04 UTC) #16
commit-bot: I haz the power
Failed to apply patch for components/offline_pages/background/BUILD.gn: While running git apply --index -p1; error: patch failed: ...
4 years ago (2016-11-29 00:18:39 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2527293002/40001
4 years ago (2016-11-29 07:35:45 UTC) #21
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-11-29 09:28:37 UTC) #23
commit-bot: I haz the power
4 years ago (2016-11-29 09:34:47 UTC) #25
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/22733070dd04a7d43e7dc3140a73b7592530dae8
Cr-Commit-Position: refs/heads/master@{#434938}

Powered by Google App Engine
This is Rietveld 408576698