[Offline pages] Adding AddRequestTask to Request Queue

[Offline pages] Adding AddRequestTask to Request Queue

This patch adds AddRequestTask with its tests to ensure request queue
operations are properly sequenced.

BUG=651238
Committed: https://crrev.com/22733070dd04a7d43e7dc3140a73b7592530dae8
Cr-Commit-Position: refs/heads/master@{#434938}

[fgorski, 2016-11-24 22:28:05]

The CQ bit was checked by fgorski@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-24 22:28:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 23:10:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 23:10:31]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[fgorski, 2016-11-28 17:02:33]

fgorski@chromium.org changed reviewers:
+ dougarnett@chromium.org, petewil@chromium.org

[fgorski, 2016-11-28 17:02:34]

PTAL.

The reason for a failure in testRemoveRequestsFromQueue is the fact that
GetRequests is not taskified in that run.

This patch should therefor land after GetRequestsTask patch.

[dougarnett, 2016-11-28 19:11:34]

https://codereview.chromium.org/2527293002/diff/1/components/offline_pages/ba...
File components/offline_pages/background/add_request_task_unittest.cc (right):

https://codereview.chromium.org/2527293002/diff/1/components/offline_pages/ba...
components/offline_pages/background/add_request_task_unittest.cc:109:
RequestQueueInMemoryStore store;
Perhaps comment that this store returns objects in the order they were added
if that is what we are counting on below for the last_requests() checks (of
GetRequestsCallback).

[fgorski, 2016-11-28 21:07:58]

The CQ bit was checked by fgorski@chromium.org to run a CQ dry run

[fgorski, 2016-11-28 21:08:03]

Addressed

https://codereview.chromium.org/2527293002/diff/1/components/offline_pages/ba...
File components/offline_pages/background/add_request_task_unittest.cc (right):

https://codereview.chromium.org/2527293002/diff/1/components/offline_pages/ba...
components/offline_pages/background/add_request_task_unittest.cc:109:
RequestQueueInMemoryStore store;
On 2016/11/28 19:11:34, dougarnett wrote:
> Perhaps comment that this store returns objects in the order they were added
> if that is what we are counting on below for the last_requests() checks (of
> GetRequestsCallback).

I actually added index calculation further down per you comment from the other
patch.

[commit-bot: I haz the power, 2016-11-28 21:08:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Pete Williamson, 2016-11-28 21:18:47]

lgtm

[dougarnett, 2016-11-28 21:27:14]

lgtm

[commit-bot: I haz the power, 2016-11-28 22:39:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-28 22:39:39]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[fgorski, 2016-11-28 23:15:31]

The CQ bit was checked by fgorski@chromium.org

[commit-bot: I haz the power, 2016-11-28 23:17:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 00:18:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 00:18:39]

Failed to apply patch for components/offline_pages/background/BUILD.gn:
While running git apply --index -p1;
  error: patch failed: components/offline_pages/background/BUILD.gn:81
  error: components/offline_pages/background/BUILD.gn: patch does not apply

Patch:       components/offline_pages/background/BUILD.gn
Index: components/offline_pages/background/BUILD.gn
diff --git a/components/offline_pages/background/BUILD.gn
b/components/offline_pages/background/BUILD.gn
index
67442cefdfe4a0012d331791984938351431783d..3e66ff5db8767bf94712b5716454d09cb9e16d4d
100644
--- a/components/offline_pages/background/BUILD.gn
+++ b/components/offline_pages/background/BUILD.gn
@@ -8,6 +8,8 @@ if (is_android) {
 
 static_library("background_offliner") {
   sources = [
+    "add_request_task.cc",
+    "add_request_task.h",
     "change_requests_state_task.cc",
     "change_requests_state_task.h",
     "device_conditions.h",
@@ -81,6 +83,7 @@ static_library("test_support") {
 source_set("unit_tests") {
   testonly = true
   sources = [
+    "add_request_task_unittest.cc",
     "change_requests_state_task_unittest.cc",
     "mark_attempt_aborted_task_unittest.cc",
     "mark_attempt_completed_task_unittest.cc",

[fgorski, 2016-11-29 07:35:27]

The CQ bit was checked by fgorski@chromium.org

[fgorski, 2016-11-29 07:35:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
dougarnett@chromium.org, petewil@chromium.org
Link to the patchset: https://codereview.chromium.org/2527293002/#ps40001
(title: "Rebased")

[commit-bot: I haz the power, 2016-11-29 07:35:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 09:28:05]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480404927565400,
"parent_rev": "271ac4c7ddc0a92c2551f1222c72af06dba427fb", "commit_rev":
"e61b721ded0cf00e1b3c09a400f2ac2b2db32d4d"}

[commit-bot: I haz the power, 2016-11-29 09:28:37]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-29 09:34:45]

Description was changed from

==========
[Offline pages] Adding AddRequestTask to Request Queue

This patch adds AddRequestTask with its tests to ensure request queue
operations are properly sequenced.

BUG=651238
==========

to

==========
[Offline pages] Adding AddRequestTask to Request Queue

This patch adds AddRequestTask with its tests to ensure request queue
operations are properly sequenced.

BUG=651238

Committed: https://crrev.com/22733070dd04a7d43e7dc3140a73b7592530dae8
Cr-Commit-Position: refs/heads/master@{#434938}
==========

[commit-bot: I haz the power, 2016-11-29 09:34:47]

Patchset 3 (id:??) landed as
https://crrev.com/22733070dd04a7d43e7dc3140a73b7592530dae8
Cr-Commit-Position: refs/heads/master@{#434938}