Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1326)

Side by Side Diff: components/offline_pages/background/request_queue.cc

Issue 2527293002: [Offline pages] Adding AddRequestTask to Request Queue (Closed)
Patch Set: Rebased Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/offline_pages/background/add_request_task_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/offline_pages/background/request_queue.h" 5 #include "components/offline_pages/background/request_queue.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/location.h" 10 #include "base/location.h"
11 #include "base/threading/thread_task_runner_handle.h" 11 #include "base/threading/thread_task_runner_handle.h"
12 #include "components/offline_pages/background/add_request_task.h"
12 #include "components/offline_pages/background/change_requests_state_task.h" 13 #include "components/offline_pages/background/change_requests_state_task.h"
13 #include "components/offline_pages/background/get_requests_task.h" 14 #include "components/offline_pages/background/get_requests_task.h"
14 #include "components/offline_pages/background/mark_attempt_aborted_task.h" 15 #include "components/offline_pages/background/mark_attempt_aborted_task.h"
15 #include "components/offline_pages/background/mark_attempt_completed_task.h" 16 #include "components/offline_pages/background/mark_attempt_completed_task.h"
16 #include "components/offline_pages/background/mark_attempt_started_task.h" 17 #include "components/offline_pages/background/mark_attempt_started_task.h"
17 #include "components/offline_pages/background/pick_request_task.h" 18 #include "components/offline_pages/background/pick_request_task.h"
18 #include "components/offline_pages/background/pick_request_task_factory.h" 19 #include "components/offline_pages/background/pick_request_task_factory.h"
19 #include "components/offline_pages/background/remove_requests_task.h" 20 #include "components/offline_pages/background/remove_requests_task.h"
20 #include "components/offline_pages/background/request_queue_store.h" 21 #include "components/offline_pages/background/request_queue_store.h"
21 #include "components/offline_pages/background/save_page_request.h" 22 #include "components/offline_pages/background/save_page_request.h"
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 void RequestQueue::GetRequests(const GetRequestsCallback& callback) { 70 void RequestQueue::GetRequests(const GetRequestsCallback& callback) {
70 std::unique_ptr<Task> task(new GetRequestsTask( 71 std::unique_ptr<Task> task(new GetRequestsTask(
71 store_.get(), base::Bind(&GetRequestsDone, callback))); 72 store_.get(), base::Bind(&GetRequestsDone, callback)));
72 task_queue_.AddTask(std::move(task)); 73 task_queue_.AddTask(std::move(task));
73 } 74 }
74 75
75 void RequestQueue::AddRequest(const SavePageRequest& request, 76 void RequestQueue::AddRequest(const SavePageRequest& request,
76 const AddRequestCallback& callback) { 77 const AddRequestCallback& callback) {
77 // TODO(fgorski): check that request makes sense. 78 // TODO(fgorski): check that request makes sense.
78 // TODO(fgorski): check that request does not violate policy. 79 // TODO(fgorski): check that request does not violate policy.
79 store_->AddRequest(request, base::Bind(&AddRequestDone, callback, request)); 80 std::unique_ptr<AddRequestTask> task(new AddRequestTask(
81 store_.get(), request, base::Bind(&AddRequestDone, callback, request)));
82 task_queue_.AddTask(std::move(task));
80 } 83 }
81 84
82 void RequestQueue::RemoveRequests(const std::vector<int64_t>& request_ids, 85 void RequestQueue::RemoveRequests(const std::vector<int64_t>& request_ids,
83 const UpdateCallback& callback) { 86 const UpdateCallback& callback) {
84 std::unique_ptr<Task> task( 87 std::unique_ptr<Task> task(
85 new RemoveRequestsTask(store_.get(), request_ids, callback)); 88 new RemoveRequestsTask(store_.get(), request_ids, callback));
86 task_queue_.AddTask(std::move(task)); 89 task_queue_.AddTask(std::move(task));
87 } 90 }
88 91
89 void RequestQueue::ChangeRequestsState( 92 void RequestQueue::ChangeRequestsState(
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
128 std::unique_ptr<Task> task(picker_factory_->CreatePickerTask( 131 std::unique_ptr<Task> task(picker_factory_->CreatePickerTask(
129 store_.get(), picked_callback, not_picked_callback, 132 store_.get(), picked_callback, not_picked_callback,
130 request_count_callback, conditions, disabled_requests)); 133 request_count_callback, conditions, disabled_requests));
131 134
132 // Queue up the picking task, it will call one of the callbacks when it 135 // Queue up the picking task, it will call one of the callbacks when it
133 // completes. 136 // completes.
134 task_queue_.AddTask(std::move(task)); 137 task_queue_.AddTask(std::move(task));
135 } 138 }
136 139
137 } // namespace offline_pages 140 } // namespace offline_pages
OLDNEW
« no previous file with comments | « components/offline_pages/background/add_request_task_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698