Add ICUError to handle ICU failures

Add ICUError to handle ICU failures

ICU reports its memory allocation failure through UErrorCode, while
Blink would like to crash the renderer using OOM_CRASH()[1].

ICUError provides the unified way to handle ICU errors in Blink.

In this CL, all failures lead to the render crash, just differently by
the error type. We may add lighter methods, such as to crash only if
critical, or to ignore certain types, if needed in future.

[1] https://groups.google.com/a/chromium.org/d/msg/platform-architecture-dev/MP0k9WGnCjA/zIBiJtilBwAJ

Committed: https://crrev.com/9a878afefb2ffcad5f064b8715e3bf625e77c4e5
Cr-Commit-Position: refs/heads/master@{#434662}

[kojii, 2016-11-24 13:44:07]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-24 13:44:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 13:47:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 13:47:33]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[kojii, 2016-11-24 14:03:34]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-24 14:04:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2016-11-24 14:10:17]

Description was changed from

==========
icuerror

BUG=
==========

to

==========
Add ICUError to handle ICU failures

ICU reports its memory allocation failure through UErrorCode, while
Blink would like to crash the renderer using OOM_CRASH()[1].

ICUError provides the unified way to handle ICU errors in Blink.

[1]
https://groups.google.com/a/chromium.org/d/msg/platform-architecture-dev/MP0k...
==========

[kojii, 2016-11-24 14:19:42]

Description was changed from

==========
Add ICUError to handle ICU failures

ICU reports its memory allocation failure through UErrorCode, while
Blink would like to crash the renderer using OOM_CRASH()[1].

ICUError provides the unified way to handle ICU errors in Blink.

[1]
https://groups.google.com/a/chromium.org/d/msg/platform-architecture-dev/MP0k...
==========

to

==========
Add ICUError to handle ICU failures

ICU reports its memory allocation failure through UErrorCode, while
Blink would like to crash the renderer using OOM_CRASH()[1].

ICUError provides the unified way to handle ICU errors in Blink.

In this CL, all failures lead to the render crash, just differently by
the error type. We may add lighter methods, such as to crash only if
critical, or to ignore certain types, if needed in future.

[1]
https://groups.google.com/a/chromium.org/d/msg/platform-architecture-dev/MP0k...
==========

[kojii, 2016-11-24 14:25:19]

kojii@chromium.org changed reviewers:
+ drott@chromium.org, eae@chromium.org, jshin@chromium.org

[kojii, 2016-11-24 14:25:19]

WDYT? ikilpatrik@ asked me what we should do when ubidi_setPara failed in the
past review, which lead me to think about this.

[commit-bot: I haz the power, 2016-11-24 15:23:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 15:23:36]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[eae, 2016-11-24 21:52:13]

Crashing on any ICU error seems a little extreme, in most cases we can probably
recover and assume that the previous or default state is valid or omit the run.
WDYT?

[kojii, 2016-11-25 02:57:15]

Yeah, I was wondering the same thing...maybe we go through error codes and pick
up what we think is critical?

At least for ubidi_setPara, most errors look like memory allocation or invalid
arguments, but haven't gone through all code paths yet.

[kojii, 2016-11-25 02:59:11]

errors are:
http://icu-project.org/apiref/icu4c/utypes_8h.html#a3343c1c8a8377277046774691...
and below the U_ZERO_ERROR are errors. Values above U_ZERO_ERROR are
U_SUCCESS().

[kojii, 2016-11-25 05:04:57]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-25 05:05:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-25 06:30:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-25 06:30:44]

Dry run: Try jobs failed on following builders:
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kojii, 2016-11-25 10:00:21]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-25 10:00:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-25 11:26:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-25 11:26:08]

Dry run: This issue passed the CQ dry run.

[eae, 2016-11-25 16:43:13]

For memory allocation and invalid argument errors I'd argue crashing is the
appropriate way to handling it. Lets try it and see what the crash rate is like.
We might have to reconsider but at least this way we'll have data!

LGTM

[kojii, 2016-11-28 14:16:59]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-28 14:17:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 15:33:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-28 15:33:59]

Dry run: This issue passed the CQ dry run.

[kojii, 2016-11-28 16:18:55]

Thank you, added invalid argument error as critical.

[kojii, 2016-11-28 16:18:59]

The CQ bit was checked by kojii@chromium.org

[kojii, 2016-11-28 16:18:59]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2527183002/#ps80001
(title: "eae review, add invalid argument error")

[commit-bot: I haz the power, 2016-11-28 16:19:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 16:22:14]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1480349939585800,
"parent_rev": "8168828d87610e996feede6120a9f213b3c3e39d", "commit_rev":
"4adc57a910c0af4dc80fa3ce7bc7406a8d39344a"}

[commit-bot: I haz the power, 2016-11-28 16:22:38]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-11-28 16:24:40]

Description was changed from

==========
Add ICUError to handle ICU failures

ICU reports its memory allocation failure through UErrorCode, while
Blink would like to crash the renderer using OOM_CRASH()[1].

ICUError provides the unified way to handle ICU errors in Blink.

In this CL, all failures lead to the render crash, just differently by
the error type. We may add lighter methods, such as to crash only if
critical, or to ignore certain types, if needed in future.

[1]
https://groups.google.com/a/chromium.org/d/msg/platform-architecture-dev/MP0k...
==========

to

==========
Add ICUError to handle ICU failures

ICU reports its memory allocation failure through UErrorCode, while
Blink would like to crash the renderer using OOM_CRASH()[1].

ICUError provides the unified way to handle ICU errors in Blink.

In this CL, all failures lead to the render crash, just differently by
the error type. We may add lighter methods, such as to crash only if
critical, or to ignore certain types, if needed in future.

[1]
https://groups.google.com/a/chromium.org/d/msg/platform-architecture-dev/MP0k...

Committed: https://crrev.com/9a878afefb2ffcad5f064b8715e3bf625e77c4e5
Cr-Commit-Position: refs/heads/master@{#434662}
==========

[commit-bot: I haz the power, 2016-11-28 16:24:41]

Patchset 5 (id:??) landed as
https://crrev.com/9a878afefb2ffcad5f064b8715e3bf625e77c4e5
Cr-Commit-Position: refs/heads/master@{#434662}