third_party/WebKit/Source/core/layout/ng/ng_inline_node.cc - Issue 2527183002: Add ICUError to handle ICU failures

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_inline_node.cc

Issue 2527183002: Add ICUError to handle ICU failures (Closed)

Patch Set: eae review, add invalid argument error Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/ng/ng_inline_node.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_inline_node.cc b/third_party/WebKit/Source/core/layout/ng/ng_inline_node.cc

index 481d4bd696de0f63bc34c0b9edbd9f4734129058..72e5ed6e9ebd908818d8bb700ec6b16b16fa4d21 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_inline_node.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_inline_node.cc

@@ -119,7 +119,6 @@ void NGInlineNode::SegmentText() {

text_content_.ensure16Bit();

if (!bidi.SetParagraph(text_content_, block_style_.get())) {

// On failure, give up bidi resolving and reordering.

- NOTREACHED();

is_bidi_enabled_ = false;

return;

}