Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 252703006: Clean up paint callbacks in player_x11 to use media::BindToCurrentLoop(). (Closed)

Created:
6 years, 8 months ago by scherkus (not reviewing)
Modified:
6 years, 7 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Clean up paint callbacks in player_x11 to use media::BindToCurrentLoop(). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266480

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -26 lines) Patch
M media/tools/player_x11/gl_video_renderer.h View 1 chunk +1 line, -1 line 0 comments Download
M media/tools/player_x11/gl_video_renderer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/tools/player_x11/player_x11.cc View 6 chunks +10 lines, -22 lines 0 comments Download
M media/tools/player_x11/x11_video_renderer.h View 1 chunk +1 line, -1 line 0 comments Download
M media/tools/player_x11/x11_video_renderer.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
scherkus (not reviewing)
I'm splitting off a bunch of tiny CLs from https://codereview.chromium.org/237353007/ this is one of them
6 years, 8 months ago (2014-04-25 23:31:46 UTC) #1
DaleCurtis
lgtm, but can't we just delete this already? :)
6 years, 8 months ago (2014-04-25 23:36:50 UTC) #2
scherkus (not reviewing)
The CQ bit was checked by scherkus@chromium.org
6 years, 8 months ago (2014-04-25 23:37:11 UTC) #3
scherkus (not reviewing)
On 2014/04/25 23:36:50, DaleCurtis wrote: > lgtm, but can't we just delete this already? :) ...
6 years, 8 months ago (2014-04-25 23:37:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/252703006/1
6 years, 8 months ago (2014-04-25 23:41:01 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-26 07:38:59 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 8 months ago (2014-04-26 07:38:59 UTC) #7
scherkus (not reviewing)
The CQ bit was checked by scherkus@chromium.org
6 years, 8 months ago (2014-04-26 19:05:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/252703006/1
6 years, 8 months ago (2014-04-26 19:05:49 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-26 20:38:06 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 8 months ago (2014-04-26 20:38:06 UTC) #11
scherkus (not reviewing)
The CQ bit was checked by scherkus@chromium.org
6 years, 8 months ago (2014-04-27 04:45:35 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/252703006/1
6 years, 8 months ago (2014-04-27 04:45:51 UTC) #13
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 07:57:33 UTC) #14
Message was sent while issue was closed.
Change committed as 266480

Powered by Google App Engine
This is Rietveld 408576698