Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3362)

Unified Diff: appengine/findit/handlers/config.py

Issue 2526963002: [Findit] Implement retry within swarming_util.py when making server calls (Closed)
Patch Set: Addressing comments Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/handlers/config.py
diff --git a/appengine/findit/handlers/config.py b/appengine/findit/handlers/config.py
index 8e713e24e14c73ec4c6c5a03fbca7e55dead141a..6efb467a50905e84e9b87a55a1f878da0da6f45b 100644
--- a/appengine/findit/handlers/config.py
+++ b/appengine/findit/handlers/config.py
@@ -167,7 +167,11 @@ def _ValidateSwarmingSettings(settings):
isinstance(settings.get('iterations_to_rerun'), int) and
isinstance(
settings.get('get_swarming_task_id_timeout_seconds'), int) and
- isinstance(settings.get('get_swarming_task_id_wait_seconds'), int))
+ isinstance(settings.get('get_swarming_task_id_wait_seconds'), int) and
+ isinstance(settings.get('server_retry_timeout_hours'), int) and
+ isinstance(settings.get(
+ 'maximum_server_contact_retry_interval_seconds'), int) and
+ isinstance(settings.get('should_retry_server'), bool))
def _ValidateDownloadBuildDataSettings(settings):
« no previous file with comments | « no previous file | appengine/findit/handlers/test/config_test.py » ('j') | appengine/findit/waterfall/swarming_util.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698