[Findit] Implement retry within swarming_util.py when making server calls

appengine/findit/handlers/config.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Handles requests to the findit config page."""
 
 import json
 
 from common.base_handler import BaseHandler
 from common.base_handler import Permission
@@ skipping 149 matching lines @@
           isinstance(settings.get('server_host'), basestring) and
           isinstance(settings.get('default_request_priority'), int) and
           isinstance(settings.get('request_expiration_hours'), int) and
           isinstance(settings.get('server_query_interval_seconds'), int) and
           isinstance(settings.get('task_timeout_hours'), int) and
           isinstance(settings.get('isolated_server'), basestring) and
           isinstance(settings.get('isolated_storage_url'), basestring) and
           isinstance(settings.get('iterations_to_rerun'), int) and
           isinstance(
               settings.get('get_swarming_task_id_timeout_seconds'), int) and
-          isinstance(settings.get('get_swarming_task_id_wait_seconds'), int))
+          isinstance(settings.get('get_swarming_task_id_wait_seconds'), int) and
+          isinstance(settings.get('server_retry_timeout_hours'), int) and
+          isinstance(settings.get(
+              'maximum_server_contact_retry_interval_seconds'), int) and
+          isinstance(settings.get('should_retry_server'), bool))
 
 
 def _ValidateDownloadBuildDataSettings(settings):
   return (isinstance(settings, dict) and
           isinstance(settings.get('download_interval_seconds'), int) and
           isinstance(settings.get(
               'memcache_master_download_expiration_seconds'), int) and
           isinstance(settings.get('use_chrome_build_extract'), bool))
 
 
@@ skipping 102 matching lines @@
     new_config_dict = json.loads(data)
     if not _ConfigurationDictIsValid(new_config_dict):  # pragma: no cover
       return self.CreateError(
           'New configuration settings is not properly formatted.', 400)
 
     wf_config.FinditConfig.Get().Update(users.get_current_user(),
                                         users.IsCurrentUserAdmin(),
                                         **new_config_dict)
 
     return self.HandleGet()