Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2526913002: Reland: [IndexedDB] Delete callbacks state on worker thread exit. (Closed)

Created:
4 years ago by Reilly Grant (use Gerrit)
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Reland: [IndexedDB] Delete callbacks state on worker thread exit. During refactoring of r430110 the logic to actually delete the internal state of IndexedDBCallbacksImpl and IndexedDBDatabaseCallbacksImpl objects that lives on worker threads was accidentally removed. This reland will fix the DCHECK encountered when actually exercising this deletion path. BUG=667465 Review-Url: https://codereview.chromium.org/2524823002 Cr-Commit-Position: refs/heads/master@{#434030} (cherry picked from commit 6d1044b605d7dfa073437e09fd966f306137a0c9) Committed: https://chromium.googlesource.com/chromium/src/+/c5646073b3867c4b59a83a502bad6ba5681816d8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -10 lines) Patch
M content/child/indexed_db/indexed_db_dispatcher.h View 2 chunks +13 lines, -4 lines 0 comments Download
M content/child/indexed_db/indexed_db_dispatcher.cc View 2 chunks +20 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Reilly Grant (use Gerrit)
4 years ago (2016-11-23 18:58:50 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c5646073b3867c4b59a83a502bad6ba5681816d8.

Powered by Google App Engine
This is Rietveld 408576698