Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 2524823002: Reland: [IndexedDB] Delete callbacks state on worker thread exit. (Closed)

Created:
4 years ago by Reilly Grant (use Gerrit)
Modified:
4 years ago
Reviewers:
jsbell
CC:
chromium-reviews, cmumford, darin-cc_chromium.org, jam, jsbell+idb_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: [IndexedDB] Delete callbacks state on worker thread exit. During refactoring of r430110 the logic to actually delete the internal state of IndexedDBCallbacksImpl and IndexedDBDatabaseCallbacksImpl objects that lives on worker threads was accidentally removed. This reland will fix the DCHECK encountered when actually exercising this deletion path. BUG=667465 Committed: https://crrev.com/6d1044b605d7dfa073437e09fd966f306137a0c9 Cr-Commit-Position: refs/heads/master@{#434030}

Patch Set 1 #

Patch Set 2 : Fix DCHECK. #

Patch Set 3 : Avoid reentrancy. #

Patch Set 4 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -10 lines) Patch
M content/child/indexed_db/indexed_db_dispatcher.h View 1 2 3 2 chunks +13 lines, -4 lines 0 comments Download
M content/child/indexed_db/indexed_db_dispatcher.cc View 1 2 3 2 chunks +20 lines, -6 lines 0 comments Download

Messages

Total messages: 24 (11 generated)
Reilly Grant (use Gerrit)
Fix DCHECK.
4 years ago (2016-11-22 19:03:16 UTC) #1
Reilly Grant (use Gerrit)
Please take another look.
4 years ago (2016-11-22 19:03:40 UTC) #4
jsbell
lgtm
4 years ago (2016-11-22 19:16:12 UTC) #6
Reilly Grant (use Gerrit)
On 2016/11/22 at 19:16:12, jsbell wrote: > lgtm No, this is still broken. :(
4 years ago (2016-11-22 19:27:48 UTC) #9
Reilly Grant (use Gerrit)
Avoid reentrancy.
4 years ago (2016-11-22 19:37:15 UTC) #10
Reilly Grant (use Gerrit)
Tested more thoroughly this time. Please take another look. I don't like that we need ...
4 years ago (2016-11-22 19:38:17 UTC) #11
jsbell
ugh, yeah. lgtm but there's so much clean-up ahead of us.
4 years ago (2016-11-22 19:45:13 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2524823002/40001
4 years ago (2016-11-22 20:23:16 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/186041)
4 years ago (2016-11-22 21:12:33 UTC) #16
Reilly Grant (use Gerrit)
Rebased.
4 years ago (2016-11-22 21:40:03 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2524823002/60001
4 years ago (2016-11-22 21:40:39 UTC) #20
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years ago (2016-11-22 23:57:37 UTC) #22
commit-bot: I haz the power
4 years ago (2016-11-23 00:00:45 UTC) #24
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/6d1044b605d7dfa073437e09fd966f306137a0c9
Cr-Commit-Position: refs/heads/master@{#434030}

Powered by Google App Engine
This is Rietveld 408576698