chromeos: Add NoteTakingHelper class.

chromeos: Add NoteTakingHelper class.

Move standalone functions from note_taking_app_utils.* into
a singleton NoteTakingHelper class. The new class doesn't
store any state yet but will soon (specifically, it'll watch
for changes to the list of available apps).

BUG=633596
Committed: https://crrev.com/1a921473256bbd8d7939f25b3d5886733ebbf95d
Cr-Commit-Position: refs/heads/master@{#436170}

[Daniel Erat, 2016-11-23 22:14:42]

The CQ bit was checked by derat@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 22:15:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 00:17:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 00:17:48]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[Daniel Erat, 2016-12-02 01:05:05]

The CQ bit was checked by derat@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 01:05:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Daniel Erat, 2016-12-02 01:07:55]

derat@chromium.org changed reviewers:
+ jdufault@chromium.org, svaldez@chromium.org, tapted@chromium.org

[Daniel Erat, 2016-12-02 01:07:55]

please take a look. thanks!

tapted: chrome/browser/ui/views/apps/
svaldez: chrome/browser/download/
jdufault: the rest

https://codereview.chromium.org/2526893003/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/note_taking_helper.h (right):

https://codereview.chromium.org/2526893003/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/note_taking_helper.h:22: static void Shutdown();
should be "ShutDown" but i'm matching what we call it everywhere else :-/

[commit-bot: I haz the power, 2016-12-02 02:02:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 02:02:59]

Dry run: This issue passed the CQ dry run.

[tapted, 2016-12-02 06:05:24]

chrome/browser/ui/views/apps/ lgtm

[jdufault, 2016-12-02 16:46:10]

lgtm

[Daniel Erat, 2016-12-02 21:21:23]

derat@chromium.org changed reviewers:
+ asanka@chromium.org, rdsmith@chromium.org

[Daniel Erat, 2016-12-02 21:21:23]

svaldez/rdsmith/asanka, would one of you mind rubber-stamping for c/b/download?
thanks!

[asanka, 2016-12-03 00:48:59]

lgtm

[Daniel Erat, 2016-12-03 01:09:47]

The CQ bit was checked by derat@chromium.org

[commit-bot: I haz the power, 2016-12-03 01:10:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-03 03:38:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-03 03:38:09]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Daniel Erat, 2016-12-03 18:22:04]

The CQ bit was checked by derat@chromium.org

[commit-bot: I haz the power, 2016-12-03 18:22:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-03 20:59:27]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480789324422520,
"parent_rev": "6eac8185ffe132905e986a0feaa6f8eab88366cf", "commit_rev":
"9f1095a588152fcdd92b0a5b7a4d0f4b83d624be"}

[commit-bot: I haz the power, 2016-12-03 20:59:56]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-03 21:03:22]

Description was changed from

==========
chromeos: Add NoteTakingHelper class.

Move standalone functions from note_taking_app_utils.* into
a singleton NoteTakingHelper class. The new class doesn't
store any state yet but will soon (specifically, it'll watch
for changes to the list of available apps).

BUG=633596
==========

to

==========
chromeos: Add NoteTakingHelper class.

Move standalone functions from note_taking_app_utils.* into
a singleton NoteTakingHelper class. The new class doesn't
store any state yet but will soon (specifically, it'll watch
for changes to the list of available apps).

BUG=633596

Committed: https://crrev.com/1a921473256bbd8d7939f25b3d5886733ebbf95d
Cr-Commit-Position: refs/heads/master@{#436170}
==========

[commit-bot: I haz the power, 2016-12-03 21:03:23]

Patchset 2 (id:??) landed as
https://crrev.com/1a921473256bbd8d7939f25b3d5886733ebbf95d
Cr-Commit-Position: refs/heads/master@{#436170}