Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4808)

Unified Diff: chrome/browser/chromeos/note_taking_app_utils.cc

Issue 2526893003: chromeos: Add NoteTakingHelper class. (Closed)
Patch Set: drop is-note-taking-app-window stuff Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/note_taking_app_utils.cc
diff --git a/chrome/browser/chromeos/note_taking_app_utils.cc b/chrome/browser/chromeos/note_taking_app_utils.cc
deleted file mode 100644
index 7f12a8da4081447fc6d397c1fde54acc820fe55b..0000000000000000000000000000000000000000
--- a/chrome/browser/chromeos/note_taking_app_utils.cc
+++ /dev/null
@@ -1,89 +0,0 @@
-// Copyright 2016 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "chrome/browser/chromeos/note_taking_app_utils.h"
-
-#include <string>
-#include <vector>
-
-#include "apps/launcher.h"
-#include "ash/common/system/chromeos/palette/palette_utils.h"
-#include "base/command_line.h"
-#include "base/files/file_path.h"
-#include "base/memory/ptr_util.h"
-#include "base/strings/string_split.h"
-#include "chrome/browser/profiles/profile.h"
-#include "chromeos/chromeos_switches.h"
-#include "extensions/browser/extension_registry.h"
-#include "extensions/common/api/app_runtime.h"
-#include "extensions/common/extension.h"
-#include "url/gurl.h"
-
-namespace app_runtime = extensions::api::app_runtime;
-
-namespace chromeos {
-namespace {
-
-// TODO(derat): Add more IDs.
-const char* const kExtensionIds[] = {
- // TODO(jdufault): Remove testing version after m54. See crbug.com/640828.
- "ogfjaccbdfhecploibfbhighmebiffla", // Testing Keep app
- "hmjkmjkepdijhoojdojkdfohbdgmmhki", // Google Keep app (Web Store)
-};
-
-// Returns the first installed and enabled whitelisted note-taking app, or null
-// if none is installed.
-const extensions::Extension* GetApp(Profile* profile) {
- // TODO(derat): Check the to-be-added "note-taking app enabled" pref here and
- // return null if it's disabled.
-
- std::vector<std::string> ids;
-
- // TODO(derat): Instead of a using hardcoded list of IDs, use an app
- // designated by a to-be-added pref.
- const std::string switch_value =
- base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII(
- switches::kNoteTakingAppIds);
- if (!switch_value.empty()) {
- ids = base::SplitString(switch_value, ",", base::TRIM_WHITESPACE,
- base::SPLIT_WANT_NONEMPTY);
- } else {
- ids.assign(kExtensionIds, kExtensionIds + arraysize(kExtensionIds));
- }
-
- const extensions::ExtensionRegistry* extension_registry =
- extensions::ExtensionRegistry::Get(profile);
- const extensions::ExtensionSet& enabled_extensions =
- extension_registry->enabled_extensions();
- for (const auto& id : ids) {
- if (enabled_extensions.Contains(id)) {
- return extension_registry->GetExtensionById(
- id, extensions::ExtensionRegistry::ENABLED);
- }
- }
- return nullptr;
-}
-
-} // namespace
-
-bool IsNoteTakingAppAvailable(Profile* profile) {
- DCHECK(profile);
- return ash::IsPaletteFeatureEnabled() && GetApp(profile);
-}
-
-void LaunchNoteTakingAppForNewNote(Profile* profile,
- const base::FilePath& path) {
- DCHECK(profile);
- const extensions::Extension* app = GetApp(profile);
- if (!app) {
- LOG(ERROR) << "Failed to find note-taking app";
- return;
- }
-
- auto action_data = base::MakeUnique<app_runtime::ActionData>();
- action_data->action_type = app_runtime::ActionType::ACTION_TYPE_NEW_NOTE;
- apps::LaunchPlatformAppWithAction(profile, app, std::move(action_data), path);
-}
-
-} // namespace chromeos

Powered by Google App Engine
This is Rietveld 408576698