Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 252683004: Reland 20962 "Break cyclic reference between utils and platform." (Closed)

Created:
6 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 8 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Reland 20962 "Break cyclic reference between utils and platform." Don't use OS::MemCopy in BitCast. It's crucial that the compiler can optimize the memcpy away. > Platform includes utils.h for the definition of Vector<>, so utils.h > can't include platform.h and has to use memcpy instead of OS::MemCopy. > > We split out Vector<> into its own header to break this cycle > dependency. > > BUG=none > R=mstarzinger@chromium.org > LOG=n > > Review URL: https://codereview.chromium.org/251753002 TBR=jkummerow@chromium.org LOG=n BUG=none Committed: https://code.google.com/p/v8/source/detail?r=20983

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+207 lines, -158 lines) Patch
M src/libplatform/default-platform.h View 1 chunk +1 line, -1 line 0 comments Download
M src/libplatform/default-platform.cc View 3 chunks +6 lines, -1 line 0 comments Download
M src/platform.h View 1 chunk +1 line, -1 line 0 comments Download
M src/utils.h View 6 chunks +4 lines, -155 lines 0 comments Download
A src/vector.h View 1 chunk +194 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
6 years, 8 months ago (2014-04-25 13:43:39 UTC) #1
jochen (gone - plz use gerrit)
Committed patchset #1 manually as r20983 (presubmit successful).
6 years, 8 months ago (2014-04-25 13:44:06 UTC) #2
Jakob Kummerow
6 years, 8 months ago (2014-04-25 13:44:50 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698