Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 251753002: Break cyclic reference between utils and platform. (Closed)

Created:
6 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 8 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Break cyclic reference between utils and platform. Platform includes utils.h for the definition of Vector<>, so utils.h can't include platform.h and has to use memcpy instead of OS::MemCopy. We split out Vector<> into its own header to break this cycle dependency. BUG=none R=mstarzinger@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=20962

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+208 lines, -159 lines) Patch
M src/libplatform/default-platform.h View 1 chunk +1 line, -1 line 2 comments Download
M src/libplatform/default-platform.cc View 3 chunks +6 lines, -1 line 0 comments Download
M src/platform.h View 1 chunk +1 line, -1 line 0 comments Download
M src/utils.h View 6 chunks +5 lines, -156 lines 0 comments Download
A src/vector.h View 1 chunk +194 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jochen (gone - plz use gerrit)
6 years, 8 months ago (2014-04-25 08:17:02 UTC) #1
Michael Starzinger
LGTM. https://codereview.chromium.org/251753002/diff/1/src/libplatform/default-platform.h File src/libplatform/default-platform.h (right): https://codereview.chromium.org/251753002/diff/1/src/libplatform/default-platform.h#newcode61 src/libplatform/default-platform.h:61: static const int kMaxThreadPoolSize; Just out of curiosity: ...
6 years, 8 months ago (2014-04-25 08:28:25 UTC) #2
jochen (gone - plz use gerrit)
https://codereview.chromium.org/251753002/diff/1/src/libplatform/default-platform.h File src/libplatform/default-platform.h (right): https://codereview.chromium.org/251753002/diff/1/src/libplatform/default-platform.h#newcode61 src/libplatform/default-platform.h:61: static const int kMaxThreadPoolSize; On 2014/04/25 08:28:25, Michael Starzinger ...
6 years, 8 months ago (2014-04-25 08:36:42 UTC) #3
jochen (gone - plz use gerrit)
Committed patchset #1 manually as r20962 (presubmit successful).
6 years, 8 months ago (2014-04-25 08:37:33 UTC) #4
ulan
6 years, 8 months ago (2014-04-25 11:35:24 UTC) #5
Message was sent while issue was closed.
On 2014/04/25 08:37:33, jochen wrote:
> Committed patchset #1 manually as r20962 (presubmit successful).

This broke fast/js/JSON-stringify.html layout test on linux64:

Threw exception RangeError: Maximum call stack size exceeded

Powered by Google App Engine
This is Rietveld 408576698