Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2526693003: Make OffscreenCanvas 2D context support globalAlpha (Closed)

Created:
4 years ago by xidachen
Modified:
4 years ago
Reviewers:
Justin Novosad
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, nhiroki, haraken, kinuko+serviceworker, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, tzik
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make OffscreenCanvas 2D context support globalAlpha We have already supported globalCompositeOperation, but globalAlpha is not exposed yet. This CL expose this attributes. Similar to the globalCompositeOperation, the implementation is already there, we just need to expose it in the .idl file. The layout test is copied from fast/canvas/2d.composite.globalAlpha.fillPath.html, with very small tweak. BUG=659260 Committed: https://crrev.com/65114caf515dfa0d606a4189a7b10d65d51c8a7a Cr-Commit-Position: refs/heads/master@{#435634}

Patch Set 1 #

Total comments: 1

Patch Set 2 : make it a reference test #

Patch Set 3 : clean up tests #

Messages

Total messages: 15 (8 generated)
xidachen
PTAL
4 years ago (2016-11-23 14:22:56 UTC) #2
xlai (Olivia)
https://codereview.chromium.org/2526693003/diff/1/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-2d-globalAlpha.html File third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-2d-globalAlpha.html (right): https://codereview.chromium.org/2526693003/diff/1/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-2d-globalAlpha.html#newcode14 third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-2d-globalAlpha.html:14: ctx.globalAlpha = 0.01; // avoid any potential alpha = ...
4 years ago (2016-11-23 17:26:43 UTC) #3
xidachen
PTAL
4 years ago (2016-12-01 14:17:46 UTC) #5
Justin Novosad
lgtm
4 years ago (2016-12-01 15:26:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2526693003/40001
4 years ago (2016-12-01 17:01:43 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-01 17:25:50 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-01 17:28:13 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/65114caf515dfa0d606a4189a7b10d65d51c8a7a
Cr-Commit-Position: refs/heads/master@{#435634}

Powered by Google App Engine
This is Rietveld 408576698