Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Unified Diff: media/video/gpu_memory_buffer_video_frame_pool_unittest.cc

Issue 2526683002: gpu: Rename AllocateGpuMemoryBuffer to CreateGpuMemoryBuffer. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/video/gpu_memory_buffer_video_frame_pool_unittest.cc
diff --git a/media/video/gpu_memory_buffer_video_frame_pool_unittest.cc b/media/video/gpu_memory_buffer_video_frame_pool_unittest.cc
index 67ece214ec13598a8f1db4d93400b23d1dbd8bae..b85319997daec1e3aecc9628db691b8c93e4a063 100644
--- a/media/video/gpu_memory_buffer_video_frame_pool_unittest.cc
+++ b/media/video/gpu_memory_buffer_video_frame_pool_unittest.cc
@@ -264,7 +264,7 @@ TEST_F(GpuMemoryBufferVideoFramePoolTest, CreateOneHardwareNV12Frame2) {
media::VideoFrameMetadata::READ_LOCK_FENCES_ENABLED));
}
-// AllocateGpuMemoryBuffer can return null (e.g: when the GPU process is down).
+// CreateGpuMemoryBuffer can return null (e.g: when the GPU process is down).
reveman 2016/11/23 15:21:59 This comment is incorrect. Gpu process being down
sadrul 2016/11/23 16:01:27 I have left the comment as is (I am not sure if I
// This test checks that in that case we don't crash and still create the
// textures.
TEST_F(GpuMemoryBufferVideoFramePoolTest, AllocateGpuMemoryBufferFail) {
reveman 2016/11/23 15:21:59 Maybe change the name of this test too. Not very i
sadrul 2016/11/23 16:01:27 I have changed this.
« no previous file with comments | « media/video/gpu_memory_buffer_video_frame_pool.cc ('k') | services/ui/public/cpp/gpu/mojo_gpu_memory_buffer_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698