Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2526663002:
Refactor xvfb.py (Closed)
|
Created:
4 years, 1 month ago by Tom (Use chromium acct) Modified:
4 years ago CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRefactor xvfb.py
This CL removes xdisplaycheck from xvfb.py. Previously, we used
xdisplaycheck to block until Xvfb set up a display. However, there's
a utility called xvfb-run that does this already, and it's included in
the xvfb package.
In future CLs, this will allow us to:
* Remove the /path/to/build_dir argument to xvfb.py since it was only
used determine the xdisplaycheck path.
* Remove xdisplaycheck from the tree
R=dpranke@chromium.org
Committed: https://crrev.com/8c5f70304b15375ea5b80ccb61617b595abfd287
Cr-Commit-Position: refs/heads/master@{#434762}
Patch Set 1 #Patch Set 2 : Fix tests #
Messages
Total messages: 30 (21 generated)
dpranke@ PTAL. The main motivation for removing xdisplaycheck is that it remains a pain point in bringing up ozone.
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Patchset #2 (id:20001) has been deleted
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/11/23 01:54:36, Tom Anderson wrote: > dpranke@ PTAL. The main motivation for removing xdisplaycheck is that it > remains a pain point in bringing up ozone. Ping. Looks like the bots are happy. And since this CL doesn't actually remove xdisplaycheck, I think it should be safe to land, right?
dpranke@chromium.org changed reviewers: + phajdan.jr@chromium.org
lgtm. phajdan.jr - fyi. For some reason I have a vague memory of xvfb-run not working for us, but I don't remember why. Maybe Paweł remembers. At any rate, I think it's safe to land this in the meantime and see what happens.
The CQ bit was checked by thomasanderson@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
The CQ bit was checked by thomasanderson@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by thomasanderson@google.com
The CQ bit was checked by thomasanderson@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480372034769100,
"parent_rev": "9cc1aaa415a332b4bc248a9839e3a97d6e867675", "commit_rev":
"de4ae8bd1d25f6201c9804f564ee9f675380f8b2"}
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Refactor xvfb.py This CL removes xdisplaycheck from xvfb.py. Previously, we used xdisplaycheck to block until Xvfb set up a display. However, there's a utility called xvfb-run that does this already, and it's included in the xvfb package. In future CLs, this will allow us to: * Remove the /path/to/build_dir argument to xvfb.py since it was only used determine the xdisplaycheck path. * Remove xdisplaycheck from the tree R=dpranke@chromium.org ========== to ========== Refactor xvfb.py This CL removes xdisplaycheck from xvfb.py. Previously, we used xdisplaycheck to block until Xvfb set up a display. However, there's a utility called xvfb-run that does this already, and it's included in the xvfb package. In future CLs, this will allow us to: * Remove the /path/to/build_dir argument to xvfb.py since it was only used determine the xdisplaycheck path. * Remove xdisplaycheck from the tree R=dpranke@chromium.org Committed: https://crrev.com/8c5f70304b15375ea5b80ccb61617b595abfd287 Cr-Commit-Position: refs/heads/master@{#434762} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/8c5f70304b15375ea5b80ccb61617b595abfd287 Cr-Commit-Position: refs/heads/master@{#434762} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
