Chromium Code Reviews| Index: components/rappor/rappor_utils.h |
| diff --git a/components/rappor/rappor_utils.h b/components/rappor/rappor_utils.h |
| index 8e425665d8eb7109aa74cdf97c990115705e0152..bb9939e18399c4decd212f0e41717c8c183507e9 100644 |
| --- a/components/rappor/rappor_utils.h |
| +++ b/components/rappor/rappor_utils.h |
| @@ -33,6 +33,14 @@ void SampleDomainAndRegistryFromGURL(RapporService* rappor_service, |
| const std::string& metric, |
| const GURL& gurl); |
| +// Records the domain and registry of a url to a Rappor metric. |
| +// If GetDefaultService is NULL or returns NULL, this call does nothing. |
| +void TrySampleDomainAndRegistryWithDefaultService(const std::string& metric, |
|
ddorwin
2016/11/28 21:45:42
Is "Try" a common pattern in the code? If not, pro
billorr
2016/11/28 23:13:03
Removing this function per your other comment.
Steven Holte
2016/11/29 20:42:09
It's still here?
billorr
2016/11/29 21:32:25
Done.
|
| + const GURL& gurl); |
| + |
| +RapporService* TryGetDefaultService(); |
|
ddorwin
2016/11/28 21:45:42
Ditto, though this should have a comment noting th
billorr
2016/11/28 23:13:03
Done.
|
| +extern RapporService* (*GetDefaultService)(); |
| + |
| } // namespace rappor |
| #endif // COMPONENTS_RAPPOR_RAPPOR_UTILS_H_ |