Re-enable rappor for vrshell

components/rappor/rappor_utils.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_RAPPOR_RAPPOR_UTILS_H_
 #define COMPONENTS_RAPPOR_RAPPOR_UTILS_H_
 
 #include <string>
 
 #include "components/rappor/rappor_service.h"
@@ skipping 15 matching lines @@
 // For file:// urls this will just return "file://" and for other special
 // schemes like chrome-extension will return the scheme and host.
 std::string GetDomainAndRegistrySampleFromGURL(const GURL& gurl);
 
 // Records the domain and registry of a url to a Rappor metric.
 // If |rappor_service| is NULL, this call does nothing.
 void SampleDomainAndRegistryFromGURL(RapporService* rappor_service,
                                      const std::string& metric,
                                      const GURL& gurl);
 
+// Records the domain and registry of a url to a Rappor metric.
+// If GetDefaultService is NULL or returns NULL, this call does nothing.
+void TrySampleDomainAndRegistryWithDefaultService(const std::string& metric,

[ddorwin, 2016/11/28 21:45:42]

Is "Try" a common pattern in the code? If not, probably drop it.

[billorr, 2016/11/28 23:13:03]

Removing this function per your other comment.

[Steven Holte, 2016/11/29 20:42:09]

It's still here?

[billorr, 2016/11/29 21:32:25]

Done.

+                                                  const GURL& gurl);
+
+RapporService* TryGetDefaultService();

[ddorwin, 2016/11/28 21:45:42]

Ditto, though this should have a comment noting that it can return NULL if there
is no such service.

[billorr, 2016/11/28 23:13:03]

Done.

+extern RapporService* (*GetDefaultService)();
+
 }  // namespace rappor
 
 #endif  // COMPONENTS_RAPPOR_RAPPOR_UTILS_H_