chrome/browser/extensions/api/principals_private/principals_private_api.h - Issue 252653002: Rename (Chrome)SyncExtensionFunction::RunImpl to RunSync so that the RunImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/principals_private/principals_private_api.h

Issue 252653002: Rename (Chrome)SyncExtensionFunction::RunImpl to RunSync so that the RunImpl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/preference/preference_api.cc ('k') | chrome/browser/extensions/api/principals_private/principals_private_api.cc » ('j') | extensions/browser/extension_function.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/principals_private/principals_private_api.h

diff --git a/chrome/browser/extensions/api/principals_private/principals_private_api.h b/chrome/browser/extensions/api/principals_private/principals_private_api.h

index 78f5981bf8e079531c72dfb18c46a9422cd7eacb..eedb6719d47c9e853633fcd56329848baff7403c 100644

--- a/chrome/browser/extensions/api/principals_private/principals_private_api.h

+++ b/chrome/browser/extensions/api/principals_private/principals_private_api.h

@@ -23,11 +23,11 @@ class PrincipalsPrivateExtensionFunction : public ChromeSyncExtensionFunction {

// ExtensionFunction:

// Checks for the flag "new-profile-management", if set calls

- // RunImplSafe which must be overriden by subclasses.

- virtual bool RunImpl() OVERRIDE FINAL;

+ // RunSyncSafe which must be overriden by subclasses.

+ virtual bool RunSync() OVERRIDE FINAL;

private:

- virtual bool RunImplSafe() = 0;

+ virtual bool RunSyncSafe() = 0;

};

class PrincipalsPrivateSignOutFunction

@@ -42,7 +42,7 @@ class PrincipalsPrivateSignOutFunction

private:

// PrincipalsPrivateExtensionFunction

- virtual bool RunImplSafe() OVERRIDE;

+ virtual bool RunSyncSafe() OVERRIDE;

DISALLOW_COPY_AND_ASSIGN(PrincipalsPrivateSignOutFunction);

};

@@ -59,7 +59,7 @@ class PrincipalsPrivateShowAvatarBubbleFunction

private:

// PrincipalsPrivateExtensionFunction

- virtual bool RunImplSafe() OVERRIDE;

+ virtual bool RunSyncSafe() OVERRIDE;

DISALLOW_COPY_AND_ASSIGN(PrincipalsPrivateShowAvatarBubbleFunction);

};