chrome/browser/extensions/api/omnibox/omnibox_api.cc - Issue 252653002: Rename (Chrome)SyncExtensionFunction::RunImpl to RunSync so that the RunImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/omnibox/omnibox_api.cc

Issue 252653002: Rename (Chrome)SyncExtensionFunction::RunImpl to RunSync so that the RunImpl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/omnibox/omnibox_api.h ('k') | chrome/browser/extensions/api/permissions/permissions_api.h » ('j') | extensions/browser/extension_function.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/omnibox/omnibox_api.cc

diff --git a/chrome/browser/extensions/api/omnibox/omnibox_api.cc b/chrome/browser/extensions/api/omnibox/omnibox_api.cc

index 5d23e5f8c220266cc44c8449a48f1e924e48d31b..8464ff0f25e7be13a72e3cafcdf513245a20f178 100644

--- a/chrome/browser/extensions/api/omnibox/omnibox_api.cc

+++ b/chrome/browser/extensions/api/omnibox/omnibox_api.cc

@@ -284,7 +284,7 @@ void BrowserContextKeyedAPIFactory<OmniboxAPI>::DeclareFactoryDependencies() {

DependsOn(TemplateURLServiceFactory::GetInstance());

}

-bool OmniboxSendSuggestionsFunction::RunImpl() {

+bool OmniboxSendSuggestionsFunction::RunSync() {

scoped_ptr<SendSuggestions::Params> params(

SendSuggestions::Params::Create(*args_));

EXTENSION_FUNCTION_VALIDATE(params);

@@ -297,7 +297,7 @@ bool OmniboxSendSuggestionsFunction::RunImpl() {

return true;

}

-bool OmniboxSetDefaultSuggestionFunction::RunImpl() {

+bool OmniboxSetDefaultSuggestionFunction::RunSync() {

scoped_ptr<SetDefaultSuggestion::Params> params(

SetDefaultSuggestion::Params::Create(*args_));

EXTENSION_FUNCTION_VALIDATE(params);