chrome/browser/extensions/api/feedback_private/feedback_private_api.h - Issue 252653002: Rename (Chrome)SyncExtensionFunction::RunImpl to RunSync so that the RunImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/feedback_private/feedback_private_api.h

Issue 252653002: Rename (Chrome)SyncExtensionFunction::RunImpl to RunSync so that the RunImpl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/extension_action/extension_action_api.cc ('k') | chrome/browser/extensions/api/feedback_private/feedback_private_api.cc » ('j') | extensions/browser/extension_function.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/feedback_private/feedback_private_api.h

diff --git a/chrome/browser/extensions/api/feedback_private/feedback_private_api.h b/chrome/browser/extensions/api/feedback_private/feedback_private_api.h

index 830e6755c24fc3013bb555f15a5a37c18591db4a..217ed7a26c9a11a6babc9de56f94a4dcf6e03d89 100644

--- a/chrome/browser/extensions/api/feedback_private/feedback_private_api.h

+++ b/chrome/browser/extensions/api/feedback_private/feedback_private_api.h

@@ -61,7 +61,7 @@ class FeedbackPrivateGetStringsFunction : public ChromeSyncExtensionFunction {

virtual ~FeedbackPrivateGetStringsFunction() {}

// SyncExtensionFunction overrides.

- virtual bool RunImpl() OVERRIDE;

+ virtual bool RunSync() OVERRIDE;

private:

static base::Closure* test_callback_;

@@ -74,7 +74,7 @@ class FeedbackPrivateGetUserEmailFunction : public ChromeSyncExtensionFunction {

protected:

virtual ~FeedbackPrivateGetUserEmailFunction() {}

- virtual bool RunImpl() OVERRIDE;

+ virtual bool RunSync() OVERRIDE;

};

class FeedbackPrivateGetSystemInformationFunction

@@ -85,7 +85,7 @@ class FeedbackPrivateGetSystemInformationFunction

protected:

virtual ~FeedbackPrivateGetSystemInformationFunction() {}

- virtual bool RunImpl() OVERRIDE;

+ virtual bool RunSync() OVERRIDE;

private:

void OnCompleted(

@@ -100,7 +100,7 @@ class FeedbackPrivateSendFeedbackFunction

protected:

virtual ~FeedbackPrivateSendFeedbackFunction() {}

- virtual bool RunImpl() OVERRIDE;

+ virtual bool RunSync() OVERRIDE;

private:

void OnCompleted(bool success);