chrome/browser/extensions/api/extension_action/extension_action_api.h - Issue 252653002: Rename (Chrome)SyncExtensionFunction::RunImpl to RunSync so that the RunImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/extension_action/extension_action_api.h

Issue 252653002: Rename (Chrome)SyncExtensionFunction::RunImpl to RunSync so that the RunImpl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/downloads/downloads_api.cc ('k') | chrome/browser/extensions/api/extension_action/extension_action_api.cc » ('j') | extensions/browser/extension_function.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/extension_action/extension_action_api.h

diff --git a/chrome/browser/extensions/api/extension_action/extension_action_api.h b/chrome/browser/extensions/api/extension_action/extension_action_api.h

index dc1b2f0f8ebae57a69c1007f8915d34e587d0125..caa82d360d66cdd91903a4718fbda5ee4ae6b855 100644

--- a/chrome/browser/extensions/api/extension_action/extension_action_api.h

+++ b/chrome/browser/extensions/api/extension_action/extension_action_api.h

@@ -125,7 +125,7 @@ class ExtensionActionFunction : public ChromeSyncExtensionFunction {

protected:

ExtensionActionFunction();

virtual ~ExtensionActionFunction();

- virtual bool RunImpl() OVERRIDE;

+ virtual bool RunSync() OVERRIDE;

virtual bool RunExtensionAction() = 0;

bool ExtractDataFromArguments();

@@ -351,7 +351,7 @@ class BrowserActionOpenPopupFunction : public ChromeAsyncExtensionFunction,

virtual ~BrowserActionOpenPopupFunction() {}

// ExtensionFunction:

- virtual bool RunImpl() OVERRIDE;

+ virtual bool RunSync() OVERRIDE;

virtual void Observe(int type,

const content::NotificationSource& source,

@@ -449,7 +449,7 @@ class EnablePageActionsFunction : public PageActionsFunction {

virtual ~EnablePageActionsFunction() {}

// ExtensionFunction:

- virtual bool RunImpl() OVERRIDE;

+ virtual bool RunSync() OVERRIDE;

};

// Implement chrome.pageActions.disableForTab().

@@ -462,7 +462,7 @@ class DisablePageActionsFunction : public PageActionsFunction {

virtual ~DisablePageActionsFunction() {}

// ExtensionFunction:

- virtual bool RunImpl() OVERRIDE;

+ virtual bool RunSync() OVERRIDE;

};

#endif // CHROME_BROWSER_EXTENSIONS_API_EXTENSION_ACTION_EXTENSION_ACTION_API_H_