Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2838)

Unified Diff: chrome/browser/extensions/api/developer_private/developer_private_api.h

Issue 252653002: Rename (Chrome)SyncExtensionFunction::RunImpl to RunSync so that the RunImpl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/developer_private/developer_private_api.h
diff --git a/chrome/browser/extensions/api/developer_private/developer_private_api.h b/chrome/browser/extensions/api/developer_private/developer_private_api.h
index 9d0e0f380703fd8a128895bf6b4517fbcfc29136..c173f0159fa11af1d52048700fb269f7a5d63be4 100644
--- a/chrome/browser/extensions/api/developer_private/developer_private_api.h
+++ b/chrome/browser/extensions/api/developer_private/developer_private_api.h
@@ -149,7 +149,7 @@ class DeveloperPrivateAutoUpdateFunction : public ChromeSyncExtensionFunction {
virtual ~DeveloperPrivateAutoUpdateFunction();
// ExtensionFunction:
- virtual bool RunImpl() OVERRIDE;
+ virtual bool RunSync() OVERRIDE;
};
class DeveloperPrivateGetItemsInfoFunction
@@ -162,7 +162,7 @@ class DeveloperPrivateGetItemsInfoFunction
virtual ~DeveloperPrivateGetItemsInfoFunction();
// ExtensionFunction:
- virtual bool RunImpl() OVERRIDE;
+ virtual bool RunSync() OVERRIDE;
private:
scoped_ptr<developer::ItemInfo> CreateItemInfo(const Extension& item,
@@ -202,7 +202,7 @@ class DeveloperPrivateInspectFunction : public ChromeSyncExtensionFunction {
virtual ~DeveloperPrivateInspectFunction();
// ExtensionFunction:
- virtual bool RunImpl() OVERRIDE;
+ virtual bool RunSync() OVERRIDE;
};
class DeveloperPrivateAllowFileAccessFunction
@@ -215,7 +215,7 @@ class DeveloperPrivateAllowFileAccessFunction
virtual ~DeveloperPrivateAllowFileAccessFunction();
// ExtensionFunction:
- virtual bool RunImpl() OVERRIDE;
+ virtual bool RunSync() OVERRIDE;
};
class DeveloperPrivateAllowIncognitoFunction
@@ -228,7 +228,7 @@ class DeveloperPrivateAllowIncognitoFunction
virtual ~DeveloperPrivateAllowIncognitoFunction();
// ExtensionFunction:
- virtual bool RunImpl() OVERRIDE;
+ virtual bool RunSync() OVERRIDE;
};
class DeveloperPrivateReloadFunction : public ChromeSyncExtensionFunction {
@@ -240,7 +240,7 @@ class DeveloperPrivateReloadFunction : public ChromeSyncExtensionFunction {
virtual ~DeveloperPrivateReloadFunction();
// ExtensionFunction:
- virtual bool RunImpl() OVERRIDE;
+ virtual bool RunSync() OVERRIDE;
};
class DeveloperPrivateShowPermissionsDialogFunction
@@ -255,7 +255,7 @@ class DeveloperPrivateShowPermissionsDialogFunction
virtual ~DeveloperPrivateShowPermissionsDialogFunction();
// ExtensionFunction:
- virtual bool RunImpl() OVERRIDE;
+ virtual bool RunSync() OVERRIDE;
// Overridden from ExtensionInstallPrompt::Delegate
virtual void InstallUIProceed() OVERRIDE;
@@ -281,7 +281,7 @@ class DeveloperPrivateEnableFunction
void OnRequirementsChecked(std::string extension_id,
std::vector<std::string> requirements_errors);
// ExtensionFunction:
- virtual bool RunImpl() OVERRIDE;
+ virtual bool RunSync() OVERRIDE;
private:
scoped_ptr<RequirementsChecker> requirements_checker_;
@@ -291,7 +291,7 @@ class DeveloperPrivateChooseEntryFunction : public ChromeAsyncExtensionFunction,
public EntryPickerClient {
protected:
virtual ~DeveloperPrivateChooseEntryFunction();
- virtual bool RunImpl() OVERRIDE;
+ virtual bool RunSync() OVERRIDE;
bool ShowPicker(ui::SelectFileDialog::Type picker_type,
const base::FilePath& last_directory,
const base::string16& select_title,
@@ -312,7 +312,7 @@ class DeveloperPrivateLoadUnpackedFunction
protected:
virtual ~DeveloperPrivateLoadUnpackedFunction();
- virtual bool RunImpl() OVERRIDE;
+ virtual bool RunSync() OVERRIDE;
// EntryPickerCLient implementation.
virtual void FileSelected(const base::FilePath& path) OVERRIDE;
@@ -327,7 +327,7 @@ class DeveloperPrivateChoosePathFunction
protected:
virtual ~DeveloperPrivateChoosePathFunction();
- virtual bool RunImpl() OVERRIDE;
+ virtual bool RunSync() OVERRIDE;
// EntryPickerClient functions.
virtual void FileSelected(const base::FilePath& path) OVERRIDE;
@@ -352,7 +352,7 @@ class DeveloperPrivatePackDirectoryFunction
protected:
virtual ~DeveloperPrivatePackDirectoryFunction();
- virtual bool RunImpl() OVERRIDE;
+ virtual bool RunSync() OVERRIDE;
private:
scoped_refptr<PackExtensionJob> pack_job_;
@@ -370,7 +370,7 @@ class DeveloperPrivateIsProfileManagedFunction
virtual ~DeveloperPrivateIsProfileManagedFunction();
// ExtensionFunction:
- virtual bool RunImpl() OVERRIDE;
+ virtual bool RunSync() OVERRIDE;
};
class DeveloperPrivateLoadDirectoryFunction
@@ -385,7 +385,7 @@ class DeveloperPrivateLoadDirectoryFunction
virtual ~DeveloperPrivateLoadDirectoryFunction();
// ExtensionFunction:
- virtual bool RunImpl() OVERRIDE;
+ virtual bool RunSync() OVERRIDE;
void ClearExistingDirectoryContent(const base::FilePath& project_path);
@@ -442,7 +442,7 @@ class DeveloperPrivateRequestFileSourceFunction
virtual ~DeveloperPrivateRequestFileSourceFunction();
// ExtensionFunction:
- virtual bool RunImpl() OVERRIDE;
+ virtual bool RunSync() OVERRIDE;
private:
void LaunchCallback(const base::DictionaryValue& results);
@@ -460,7 +460,7 @@ class DeveloperPrivateOpenDevToolsFunction
virtual ~DeveloperPrivateOpenDevToolsFunction();
// ExtensionFunction:
- virtual bool RunImpl() OVERRIDE;
+ virtual bool RunSync() OVERRIDE;
};
} // namespace api

Powered by Google App Engine
This is Rietveld 408576698