chrome/browser/chromeos/extensions/first_run_private_api.cc - Issue 252653002: Rename (Chrome)SyncExtensionFunction::RunImpl to RunSync so that the RunImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/first_run_private_api.cc

Issue 252653002: Rename (Chrome)SyncExtensionFunction::RunImpl to RunSync so that the RunImpl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/extensions/first_run_private_api.h ('k') | chrome/browser/chromeos/extensions/info_private_api.h » ('j') | extensions/browser/extension_function.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/extensions/first_run_private_api.cc

diff --git a/chrome/browser/chromeos/extensions/first_run_private_api.cc b/chrome/browser/chromeos/extensions/first_run_private_api.cc

index edbda7473ad7641e6d4c24971390356514a68ac8..9f56c96d70654afa47abb10b605344cfe2b8f7b6 100644

--- a/chrome/browser/chromeos/extensions/first_run_private_api.cc

+++ b/chrome/browser/chromeos/extensions/first_run_private_api.cc

@@ -14,7 +14,7 @@

#include "ui/base/l10n/l10n_util.h"

#include "ui/base/webui/web_ui_util.h"

-bool FirstRunPrivateGetLocalizedStringsFunction::RunImpl() {

+bool FirstRunPrivateGetLocalizedStringsFunction::RunSync() {

UMA_HISTOGRAM_COUNTS("CrosFirstRun.DialogShown", 1);

base::DictionaryValue* localized_strings = new base::DictionaryValue();

chromeos::User* user =

@@ -50,7 +50,7 @@ bool FirstRunPrivateGetLocalizedStringsFunction::RunImpl() {

return true;

}

-bool FirstRunPrivateLaunchTutorialFunction::RunImpl() {

+bool FirstRunPrivateLaunchTutorialFunction::RunSync() {

chromeos::first_run::LaunchTutorial();

return true;

}