chrome/browser/chromeos/extensions/echo_private_api.h - Issue 252653002: Rename (Chrome)SyncExtensionFunction::RunImpl to RunSync so that the RunImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/echo_private_api.h

Issue 252653002: Rename (Chrome)SyncExtensionFunction::RunImpl to RunSync so that the RunImpl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/accessibility/accessibility_extension_api.cc ('k') | chrome/browser/chromeos/extensions/echo_private_api.cc » ('j') | extensions/browser/extension_function.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/extensions/echo_private_api.h

diff --git a/chrome/browser/chromeos/extensions/echo_private_api.h b/chrome/browser/chromeos/extensions/echo_private_api.h

index b22f586ee0a9ae3df3893452ac3e7d789c395e90..3435501c514af6bee769357584c21ac8dd251492 100644

--- a/chrome/browser/chromeos/extensions/echo_private_api.h

+++ b/chrome/browser/chromeos/extensions/echo_private_api.h

@@ -31,7 +31,7 @@ class EchoPrivateGetRegistrationCodeFunction

protected:

virtual ~EchoPrivateGetRegistrationCodeFunction();

- virtual bool RunImpl() OVERRIDE;

+ virtual bool RunSync() OVERRIDE;

private:

void GetRegistrationCode(const std::string& type);

@@ -46,7 +46,7 @@ class EchoPrivateGetOobeTimestampFunction

protected:

virtual ~EchoPrivateGetOobeTimestampFunction();

- virtual bool RunImpl() OVERRIDE;

+ virtual bool RunSync() OVERRIDE;

private:

bool GetOobeTimestampOnFileThread();

@@ -60,7 +60,7 @@ class EchoPrivateSetOfferInfoFunction : public ChromeSyncExtensionFunction {

protected:

virtual ~EchoPrivateSetOfferInfoFunction();

- virtual bool RunImpl() OVERRIDE;

+ virtual bool RunSync() OVERRIDE;

private:

DECLARE_EXTENSION_FUNCTION("echoPrivate.setOfferInfo",

@@ -73,7 +73,7 @@ class EchoPrivateGetOfferInfoFunction : public ChromeSyncExtensionFunction {

protected:

virtual ~EchoPrivateGetOfferInfoFunction();

- virtual bool RunImpl() OVERRIDE;

+ virtual bool RunSync() OVERRIDE;

private:

DECLARE_EXTENSION_FUNCTION("echoPrivate.getOfferInfo",

@@ -102,7 +102,7 @@ class EchoPrivateGetUserConsentFunction : public ChromeAsyncExtensionFunction,

protected:

virtual ~EchoPrivateGetUserConsentFunction();

- virtual bool RunImpl() OVERRIDE;

+ virtual bool RunSync() OVERRIDE;

private:

// chromeos::EchoDialogListener overrides.