third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.h - Issue 2526343003: Introduce new security restrictions in FetchEvent.respondWith().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.h

Issue 2526343003: Introduce new security restrictions in FetchEvent.respondWith(). (Closed)

Patch Set: incorporated falken's comment Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/serviceworkers/ForeignFetchRespondWithObserver.cpp ('k') | third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.h

diff --git a/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.h b/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.h

index 087d06b42cd5af70093fad1642ec7778286340fb..b7f049ab71a660883905437aa868ee5e5b1dd7f0 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.h

+++ b/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.h

@@ -35,6 +35,7 @@ class MODULES_EXPORT RespondWithObserver

int fetchEventID,

const KURL& requestURL,

WebURLRequest::FetchRequestMode,

+ WebURLRequest::FetchRedirectMode,

WebURLRequest::FrameType,

WebURLRequest::RequestContext,

WaitUntilObserver*);

@@ -58,6 +59,7 @@ class MODULES_EXPORT RespondWithObserver

int fetchEventID,

const KURL& requestURL,

WebURLRequest::FetchRequestMode,

+ WebURLRequest::FetchRedirectMode,

WebURLRequest::FrameType,

WebURLRequest::RequestContext,

WaitUntilObserver*);

@@ -65,11 +67,12 @@ class MODULES_EXPORT RespondWithObserver

private:

class ThenFunction;

- int m_fetchEventID;

- KURL m_requestURL;

- WebURLRequest::FetchRequestMode m_requestMode;

- WebURLRequest::FrameType m_frameType;

- WebURLRequest::RequestContext m_requestContext;

+ const int m_fetchEventID;

+ const KURL m_requestURL;

+ const WebURLRequest::FetchRequestMode m_requestMode;

+ const WebURLRequest::FetchRedirectMode m_redirectMode;

+ const WebURLRequest::FrameType m_frameType;

+ const WebURLRequest::RequestContext m_requestContext;

falken 2016/12/13 04:43:39 like the consts

double m_eventDispatchTime = 0;